<div dir="ltr">On Wed, Nov 27, 2013 at 2:33 AM, Aurélien Gâteau <span dir="ltr"><<a href="mailto:agateau@kde.org" target="_blank">agateau@kde.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Le vendredi 22 novembre 2013 19:55:52 Ben Cooksley a écrit :<br>
<div><div class="h5">> On Fri, Nov 22, 2013 at 3:52 AM, Aurélien Gâteau <<a href="mailto:agateau@kde.org">agateau@kde.org</a>> wrote:<br>
> > Hi,<br>
><br>
> Hi,<br>
><br>
> > This morning I merged my superbuild changes in the frameworks branch.<br>
> ><br>
> > Superbuild support was originally enabled by default, but I turned it<br>
> > off because it broke on <a href="http://build.kde.org" target="_blank">build.kde.org</a>. You can turn it on by passing<br>
> > -DSUPERBUILD=ON to cmake. When superbuild is enabled, you can build any<br>
> > framework standalone with `make sb_$framework`. This will:<br>
> ><br>
> > - create a separate build dir for the framework in<br>
> ><br>
> > $build/superbuild/$framework<br>
> ><br>
> > - run cmake in this dir<br>
> > - run make<br>
> > - run make install<br>
> ><br>
> > You can also build all frameworks standalone at once with `make sb_all`.<br>
> ><br>
> > Regarding <a href="http://build.kde.org" target="_blank">build.kde.org</a>: build failed because it defines a DESTDIR<br>
> > environment variable but does not set CMAKE_SKIP_RPATH, which superbuild<br>
> ><br>
> > does not like:<br>
> > CMake Error at superbuild/SuperBuild.cmake:61 (message):<br>
> > The DESTDIR environment variable is set to<br>
> > "/srv/jenkins/workspace/kdelibs_frameworks_qt5/install", but<br>
> > CMAKE_SKIP_RPATH is not set to TRUE. This would produce binaries<br>
> ><br>
> > with bad<br>
> ><br>
> > RPATHs.<br>
> ><br>
> > Call Stack (most recent call first):<br>
> > superbuild/CMakeLists.txt:7 (include)<br>
> ><br>
> > I am not sure what is the best approach to this, advices are welcome.<br>
> ><br>
> ><br>
> > Once this is sorted out, I would like to see <a href="http://build.kde.org" target="_blank">build.kde.org</a> run `make<br>
> > sb_all` before running the classic `make` command so that we can catch<br>
> > standalone breakage.<br>
><br>
> We can do that.<br>
><br>
> In terms of CMAKE_SKIP_RPATH, that sounds like a bad idea as it will<br>
> probably break things like meinproc5 for the regular (non-Super) build.<br>
> I've no idea why it is complaining about DESTDIR being set - it should have<br>
> no effect as far as I know, but i'm no expert in these matters.<br>
><br>
> I'd suggest disabling this check if we can, but i'll defer to those who<br>
> know more in the area of RPATH and equivalent variables.<br>
> Up to this point it has not caused us any issues wrt execution of tests for<br>
> any of the binaries used on the CI system - otherwise CMake itself,<br>
> kdeinit, kded, etc wouldn't work.<br></div></div></blockquote><div><br></div><div style>Hi,</div><div style> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div class="h5">
<br>
</div></div>I just disabled it, so that you can give it a try. Can you modify kdelibs job<br>
definition so that cmake is called with -DSUPERBUILD=ON and "make sb_all" is<br>
called first, then "make"?<br></blockquote><div><br></div><div style>That has now been done in 6a67a97e79f1c0251bf0038e8ecd46dbe59cae72 to sysadmin/build-kde-org.</div><div style>Unfortunately the build failed.</div>
<div style> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><font color="#888888"><br>
Aurélien<br>
</font></span></blockquote></div><br></div><div class="gmail_extra" style>Thanks,</div><div class="gmail_extra" style>Ben</div></div>