<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113910/">http://git.reviewboard.kde.org/r/113910/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 5c4f98aff6bca46e1523a79d8d5148354e786f52 by Maarten De Meyer to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On November 25th, 2013, 2:46 p.m. UTC, Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2013, 2:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds 2 examples to KArchive.
- helloworld: Very basic. Shows how to use with CMake and create archives.
- tarlocalfiles: Shows how to add local files to an archive.
Looking for feedback on:
License? Currently BSD.
Code comments. More, less?
Readability?
Other examples I'm working on:
helloworld with qmake
something with KCompressionDevice
perhaps a minimal ark like example</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds and runs without errors.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/karchive/examples/helloworld/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/karchive/examples/helloworld/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/karchive/examples/tarlocalfiles/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/karchive/examples/tarlocalfiles/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113910/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>