<div dir="ltr">On Fri, Nov 22, 2013 at 3:52 AM, Aurélien Gâteau <span dir="ltr"><<a href="mailto:agateau@kde.org" target="_blank">agateau@kde.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br></blockquote><div><br></div><div style>Hi,</div><div style> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
This morning I merged my superbuild changes in the frameworks branch.<br>
<br>
Superbuild support was originally enabled by default, but I turned it<br>
off because it broke on <a href="http://build.kde.org" target="_blank">build.kde.org</a>. You can turn it on by passing<br>
-DSUPERBUILD=ON to cmake. When superbuild is enabled, you can build any<br>
framework standalone with `make sb_$framework`. This will:<br>
<br>
- create a separate build dir for the framework in<br>
$build/superbuild/$framework<br>
- run cmake in this dir<br>
- run make<br>
- run make install<br>
<br>
You can also build all frameworks standalone at once with `make sb_all`.<br>
<br>
Regarding <a href="http://build.kde.org" target="_blank">build.kde.org</a>: build failed because it defines a DESTDIR<br>
environment variable but does not set CMAKE_SKIP_RPATH, which superbuild<br>
does not like:<br>
<br>
CMake Error at superbuild/SuperBuild.cmake:61 (message):<br>
The DESTDIR environment variable is set to<br>
"/srv/jenkins/workspace/<u></u>kdelibs_frameworks_qt5/<u></u>install", but<br>
CMAKE_SKIP_RPATH is not set to TRUE. This would produce binaries with bad<br>
RPATHs.<br>
Call Stack (most recent call first):<br>
superbuild/CMakeLists.txt:7 (include)<br>
<br>
I am not sure what is the best approach to this, advices are welcome. </blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Once this is sorted out, I would like to see <a href="http://build.kde.org" target="_blank">build.kde.org</a> run `make<br>
sb_all` before running the classic `make` command so that we can catch<br>
standalone breakage.<br></blockquote><div><br></div><div style>We can do that.</div><div style><br></div><div style>In terms of CMAKE_SKIP_RPATH, that sounds like a bad idea as it will probably break things like meinproc5 for the regular (non-Super) build.</div>
<div style>I've no idea why it is complaining about DESTDIR being set - it should have no effect as far as I know, but i'm no expert in these matters. </div><div style><br></div><div style>I'd suggest disabling this check if we can, but i'll defer to those who know more in the area of RPATH and equivalent variables.</div>
<div style>Up to this point it has not caused us any issues wrt execution of tests for any of the binaries used on the CI system - otherwise CMake itself, kdeinit, kded, etc wouldn't work.</div><div style><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Aurélien<br>
<br>
<a href="http://build.kde.org/job/kdelibs_frameworks_qt5/1718/console" target="_blank">http://build.kde.org/job/<u></u>kdelibs_frameworks_qt5/1718/<u></u>console</a><br>
<br></blockquote><div><br></div><div style>Regards,</div><div style>Ben </div></div><br></div></div>