<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113949/">http://git.reviewboard.kde.org/r/113949/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6f11c4fb9fbae6e38f542a5dbde07dd7dea15606 by Aurélien Gâteau to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On November 19th, 2013, 6:19 p.m. UTC, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Sebastian Kügler.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Nov. 19, 2013, 6:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is currently no way to declare a target as a dependency of the automoc
target, so it is not possible to ensure .json files are generated from .desktop
files before moc is run. To work around this, generate .json files at configure
time.
This is a workaround because it means changes to .desktop files won't be applied
to .json files when building, one will need to re-run cmake.
This changes adds a test to ensure the CMake macro works well. It is declared as
an external project because it needs desktoptojson to be installed to work
correctly.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdelibs still builds, repositories such as kde-runtime and kde-workspace build as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier3/kservice/KServiceMacros.cmake <span style="color: grey">(d5b30ce)</span></li>
<li>tier3/kservice/src/desktoptojson/CMakeLists.txt <span style="color: grey">(9dc8635)</span></li>
<li>tier3/kservice/tests/kservicetojsontest/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kservice/tests/kservicetojsontest/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kservice/tests/kservicetojsontest/dummy-service.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kservice/tests/kservicetojsontest/dummyplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kservice/tests/kservicetojsontest/dummyplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113949/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>