<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113631/">http://git.reviewboard.kde.org/r/113631/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 10th, 2013, 5:08 p.m. UTC, <b>Patrick von Reth</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please use winsock2.h instead of winsock.h</pre>
</blockquote>
<p>On November 15th, 2013, 6:21 p.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alexander? Any chance to see this comment addressed?</pre>
</blockquote>
<p>On November 15th, 2013, 7:06 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops somehow didn't see that comment. Sure I will fix it right away. Any other objections or can I commit after changing the include?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No objection. Please fix and commit right away.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On November 10th, 2013, 3:46 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Patrick Spendrin and Patrick von Reth.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2013, 3:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allow compiling kwindowsystem on Windows</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles (Windows 7, VS 2012 x64)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/CMakeLists.txt <span style="color: grey">(277b3f0)</span></li>
<li>tier1/kwindowsystem/CMakeLists.txt <span style="color: grey">(dc8fcae)</span></li>
<li>tier1/kwindowsystem/src/CMakeLists.txt <span style="color: grey">(d9d141e)</span></li>
<li>tier1/kwindowsystem/src/kkeyserver_win.h <span style="color: grey">(6328f41)</span></li>
<li>tier1/kwindowsystem/src/kstartupinfo.h <span style="color: grey">(39c2935)</span></li>
<li>tier1/kwindowsystem/src/kstartupinfo.cpp <span style="color: grey">(402cc97)</span></li>
<li>tier1/kwindowsystem/src/kwindowinfo_win.cpp <span style="color: grey">(d392fe9)</span></li>
<li>tier1/kwindowsystem/src/kwindowsystem.h <span style="color: grey">(0c6a930)</span></li>
<li>tier1/kwindowsystem/src/kwindowsystem_win.cpp <span style="color: grey">(23a6616)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113631/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>