<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113881/">http://git.reviewboard.kde.org/r/113881/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 805ce7a14f5333509852b460e46e61b55d467490 by Alex Merry to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On November 15th, 2013, 12:20 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2013, 12:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Standardise d-pointer classes of kmediaplayer
Use "class Private" instead of "struct Data", for consistency with other
KDE software, and move all private members to those classes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kmediaplayer/src/kmediaplayer/view.h <span style="color: grey">(3bc849f5d93b5bb04c811c0c598d1f27fb25bfc2)</span></li>
<li>staging/kmediaplayer/src/kmediaplayer/player.cpp <span style="color: grey">(a4618c4b1d93e2203cea496c100a0ed4ebe4d8dd)</span></li>
<li>staging/kmediaplayer/src/kmediaplayer/player.h <span style="color: grey">(c59c06fca0ea22994a7f00c6c509777be09370f1)</span></li>
<li>staging/kmediaplayer/src/kmediaplayer/view.cpp <span style="color: grey">(eb2b779e8a4b044c1aa4f57b15567688da51a626)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113881/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>