<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113851/">http://git.reviewboard.kde.org/r/113851/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 15th, 2013, 9:38 a.m. CET, <b>Commit Hook</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 00e39e1d2a8372c991e24383d7c45ea393522ca8 by Aurélien Gâteau to branch frameworks.</pre>
</blockquote>
<p>On November 15th, 2013, 9:39 a.m. CET, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Decided to push it without a "ship it": it fixes the build of kde-workspace on build.kde.org and a few people looked at it without being horrified.</pre>
</blockquote>
<p>On November 15th, 2013, 9:42 a.m. CET, <b>Dario Freddi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not a big deal, the patch wasn't really intrusive. OTOH, 24hrs is still a decent reaction time :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> 24hrs is still a decent reaction time :)
True, sorry for that.
Thanks for reviewing it.</pre>
<br />
<p>- Aurélien</p>
<br />
<p>On November 15th, 2013, 9:38 a.m. CET, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Dario Freddi.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2013, 9:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a two-commit patch, it fixes a build failure in kde-workspace/kcontrol/dateandtime.
1. make policy-gen accept a second argument pointing to the output file
2. Unbreak call to kauth-policy-gen
Uses the new kauth-policy-gen syntax for extra safety (no empty output file
gets created in case of failure)
Note: I haven't tested the Mac part of the code. Would be awesome if someone could give it a try.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still builds, kcmclock_actions.policy is correctly generated in kde-workspace/kcontrol/dateandtime</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier2/kauth/KAuthConfig.cmake.in <span style="color: grey">(67eb7de)</span></li>
<li>tier2/kauth/cmake/KAuthMacros.cmake <span style="color: grey">(1ebc889)</span></li>
<li>tier2/kauth/src/CMakeLists.txt <span style="color: grey">(68c7c37)</span></li>
<li>tier2/kauth/src/policy-gen/policy-gen.cpp <span style="color: grey">(b00e09f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113851/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>