<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113825/">http://git.reviewboard.kde.org/r/113825/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit f3a33e60d5c58e12dc841fb938c38ef535f6e496 by Alex Merry to branch frameworks.</pre>
 <br />









<p>- Commit Hook</p>


<br />
<p>On November 12th, 2013, 10:09 p.m. UTC, Alex Merry wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>


<p style="color: grey;"><i>Updated Nov. 12, 2013, 10:09 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move kmediaplayer to staging (and fix its CMake files)

This moves kmediaplayer to staging as its own frameworks, rearranges its
directory structure and fixes its CMake files.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, installs.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>interfaces/CMakeLists.txt <span style="color: grey">(9fa4e1b23e4671dae25518c9d8d3fe1369f9b1a6)</span></li>

 <li>interfaces/kmediaplayer/CMakeLists.txt <span style="color: grey">(0f087c7f026cfd123251cbac9ecf40d12318a907)</span></li>

 <li>interfaces/kmediaplayer/Mainpage.dox <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/kfileaudiopreview/CMakeLists.txt <span style="color: grey">(56ef84d2cac87f9f762c6470ff136c87cf39ed25)</span></li>

 <li>interfaces/kmediaplayer/kfileaudiopreview/Messages.sh <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/kfileaudiopreview/kfileaudiopreview.h <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/kfileaudiopreview/kfileaudiopreview.cpp <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/kfileaudiopreview/mediacontrols.h <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/kfileaudiopreview/mediacontrols.cpp <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/kfileaudiopreview/mediacontrols_p.h <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/kmediaplayer.desktop <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/kmediaplayeradaptor.cpp <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/kmediaplayeradaptor_p.h <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/kmediaplayerengine.desktop <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/org.kde.KMediaPlayer.xml <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/player.h <span style="color: grey">(64275e127d9e9580de7ab7c6675ab8d8b83fe651)</span></li>

 <li>interfaces/kmediaplayer/player.cpp <span style="color: grey">(531d96847c847b5ca970141c37afc936705bda8c)</span></li>

 <li>interfaces/kmediaplayer/view.h <span style="color: grey">()</span></li>

 <li>interfaces/kmediaplayer/view.cpp <span style="color: grey">(0f3cbd53f600d4d75b278d2183e4214372ab85cd)</span></li>

 <li>staging/CMakeLists.txt <span style="color: grey">(c77fa19ad700c6e9af68434d7c6fdc304fceeba6)</span></li>

 <li>staging/kmediaplayer/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>staging/kmediaplayer/KMediaPlayerConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>

 <li>staging/kmediaplayer/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>staging/kmediaplayer/src/kfileaudiopreview/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>staging/kmediaplayer/src/kmediaplayer/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113825/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>