<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113685/">http://git.reviewboard.kde.org/r/113685/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 12th, 2013, 10:49 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">About the .colors translations, we have this
./kdeui/colors/kcolordialog.cpp:104: { "40.colors", I18N_NOOP2("palette name", "Forty Colors") },
./kdeui/colors/kcolordialog.cpp:105: { "Oxygen.colors", I18N_NOOP2("palette name", "Oxygen Colors") },
./kdeui/colors/kcolordialog.cpp:106: { "Rainbow.colors", I18N_NOOP2("palette name", "Rainbow Colors") },
./kdeui/colors/kcolordialog.cpp:107: { "Royal.colors", I18N_NOOP2("palette name", "Royal Colors") },
./kdeui/colors/kcolordialog.cpp:108: { "Web.colors", I18N_NOOP2("palette name", "Web Colors") },
Not sure if this is the only place that it's used or not. Maybe we need a more central class that handles for you the search for "*.colors" and then gives you both an "internal" name and an "user visible" name?</pre>
</blockquote>
<p>On November 13th, 2013, 5:46 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That doesn't look like a useable solution. Kcolordialog lives in kde4support while the .colors are in kde-workspace. I think the translations would need to go with the .colors files directly.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm... But what do the .colors files which are, as far as I know palettes, have to do with color themes for apps?</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On November 12th, 2013, 8:48 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Albert Astals Cid, Gilles Caulier, and Boudewijn Rempt.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2013, 8:48 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This class is inspired by functionality offered by e.g. Krita and
Digikam to allow the user to select a different color scheme for the
application.
This manager simplifies this task and also ensures that the required
property on QApplication is set, so that a QStyle can pass the scheme
to the window manager/compositor for the windows of the application.
@boud and @cgilles: please have a look whether this approach is sufficient for your usecases in digkam and Krita.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see demo application</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier3/kconfigwidgets/src/CMakeLists.txt <span style="color: grey">(36ffca8)</span></li>
<li>tier3/kconfigwidgets/src/kcolorschememanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kconfigwidgets/src/kcolorschememanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kconfigwidgets/src/kcolorschememanager_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kconfigwidgets/tests/CMakeLists.txt <span style="color: grey">(f66dc32)</span></li>
<li>tier3/kconfigwidgets/tests/kcolorschemedemo.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113685/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>