<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113723/">http://git.reviewboard.kde.org/r/113723/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 9th, 2013, 12:47 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113723/diff/1/?file=212052#file212052line34" style="color: black; font-weight: bold; text-decoration: underline;">staging/kio/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">34</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">find_package</span><span class="p">(</span><span class="s">KDED</span> <span class="o">${</span><span class="nv">KF5_VERSION</span><span class="o">}</span> <span class="s">REQUIRED</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why? KDED doesn't provide a library.</pre>
</blockquote>
<p>On November 10th, 2013, 3:14 a.m. UTC, <b>Àlex Fiestas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It provides a DBus interface (.xml) that is installed and later on used in kcookiejar to generate c++ code.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, I see, the command-line tool kcookiejar5 uses kded.loadModule and kded.unloadModule.
We could get rid of the compile-time dependency by making dynamic dbus calls, but the runtime dependency would still exist anyway, so not much point.
OK then -- please add a comment on that line like # for org.kde.kded5.xml</pre>
<br />
<p>- David</p>
<br />
<p>On November 8th, 2013, 5:01 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Nov. 8, 2013, 5:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As you will see, this splitting was a bit harder than others:
- KIO was using a couple of private headers from kjobwidgets, which now they will be installed.
- The xslt_kde target was being used from KDocTools without having it exported. Now it will be properly exported.
- Also defines all dependencies so it can be compiled independently, modularization is done as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, Installs, tests still pass; both modularized and monolithic kdelibs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier2/kdoctools/src/CMakeLists.txt <span style="color: grey">(3940e98)</span></li>
<li>tier2/kdoctools/KDocToolsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier2/kdoctools/KDocToolsConfig.cmake <span style="color: grey">(d501dc8)</span></li>
<li>tier2/kdoctools/CMakeLists.txt <span style="color: grey">(c2256ff)</span></li>
<li>superbuild/CMakeLists.txt <span style="color: grey">(458fb4c)</span></li>
<li>tier1/kcoreaddons/src/lib/CMakeLists.txt <span style="color: grey">(fad55c5)</span></li>
<li>staging/kio/tests/CMakeLists.txt <span style="color: grey">(6cee291)</span></li>
<li>staging/kio/src/widgets/CMakeLists.txt <span style="color: grey">(d90386d)</span></li>
<li>staging/kio/src/ioslaves/http/tests/CMakeLists.txt <span style="color: grey">(52c9f6c)</span></li>
<li>staging/kio/src/ioslaves/http/kcookiejar/CMakeLists.txt <span style="color: grey">(b0feff6)</span></li>
<li>staging/kio/src/ioslaves/help/CMakeLists.txt <span style="color: grey">(40637dc)</span></li>
<li>staging/kio/src/filewidgets/CMakeLists.txt <span style="color: grey">(31fe8c6)</span></li>
<li>staging/kio/CMakeLists.txt <span style="color: grey">(6c7297e)</span></li>
<li>cmake/modules/FindGSSAPI.cmake <span style="color: grey">()</span></li>
<li>cmake/modules/CMakeLists.txt <span style="color: grey">(7910270)</span></li>
<li>tier3/kded/KDEDConfig.cmake.in <span style="color: grey">(32f8d56)</span></li>
<li>tier3/kservice/src/CMakeLists.txt <span style="color: grey">(cc0c1a4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113723/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>