<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113696/">http://git.reviewboard.kde.org/r/113696/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No change was needed in CMakeLists.txt, therefore it's correct (provided that "make install" still works) :)</pre>
<br />
<p>- David Faure</p>
<br />
<p>On November 6th, 2013, 7:17 p.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2013, 7:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Renamed knewstuff private headers to _p.h and adjusted #include's accordingly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It still builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier3/knewstuff/src/attica/atticaprovider.h <span style="color: grey">(38aacfa377c91c54951eec9923f9b1712a0f4e32)</span></li>
<li>tier3/knewstuff/src/attica/atticaprovider.cpp <span style="color: grey">(b077b23a3decb644b6ab5d15dc1283dfcd0e05b2)</span></li>
<li>tier3/knewstuff/src/core/author.h <span style="color: grey">()</span></li>
<li>tier3/knewstuff/src/core/author.cpp <span style="color: grey">(12cde54d806fdf674fb413d59a586db831de082d)</span></li>
<li>tier3/knewstuff/src/core/cache.h <span style="color: grey">(03373377cb91df9d5448e6231b008bd7949a8364)</span></li>
<li>tier3/knewstuff/src/core/cache.cpp <span style="color: grey">(66e3ed13c690437cbbb3a43a518e22b5d5240581)</span></li>
<li>tier3/knewstuff/src/core/engine.h <span style="color: grey">(7f0bc3021ef21b1621bff51fcb76e0579452f6e7)</span></li>
<li>tier3/knewstuff/src/core/engine.cpp <span style="color: grey">(941b1d0753320f57641c868f94959d9bf93148f7)</span></li>
<li>tier3/knewstuff/src/core/entryinternal.h <span style="color: grey">(08f6dcf02e0a765a80a0df24375381e1d6fdf909)</span></li>
<li>tier3/knewstuff/src/core/entryinternal.cpp <span style="color: grey">(2eb592d771dbc3f5ec1e38b7c7d0231b49736543)</span></li>
<li>tier3/knewstuff/src/core/installation.h <span style="color: grey">(aec5e71d449a3e13108e636553a721b56a1af08f)</span></li>
<li>tier3/knewstuff/src/core/installation.cpp <span style="color: grey">(7ec710ac80ae2011e9d975aa5d00763b04b084bd)</span></li>
<li>tier3/knewstuff/src/core/provider.h <span style="color: grey">(0e3f7bc6efd3d205442c70d79035984848a1b7c8)</span></li>
<li>tier3/knewstuff/src/core/provider.cpp <span style="color: grey">(294d8665971e8547abfccd47785f655a85d8796b)</span></li>
<li>tier3/knewstuff/src/core/security.h <span style="color: grey">()</span></li>
<li>tier3/knewstuff/src/core/security.cpp <span style="color: grey">(eec03c39d3f1b5296ddd81525f4868359b46497c)</span></li>
<li>tier3/knewstuff/src/core/upload.h <span style="color: grey">()</span></li>
<li>tier3/knewstuff/src/core/upload.cpp <span style="color: grey">(ef62cf10ad1d580df8b894ac70044ad9a286b827)</span></li>
<li>tier3/knewstuff/src/core/xmlloader.h <span style="color: grey">()</span></li>
<li>tier3/knewstuff/src/core/xmlloader.cpp <span style="color: grey">(65b6de95c4902adb1beb2761dec54d7526036b2b)</span></li>
<li>tier3/knewstuff/src/downloadmanager.cpp <span style="color: grey">(df06786b0cf136c2f7f52e85cbeb7a61835acad6)</span></li>
<li>tier3/knewstuff/src/downloadwidget.cpp <span style="color: grey">(1d56e1106fb3ce1aa3f4a7f3b07a68732101b3ce)</span></li>
<li>tier3/knewstuff/src/downloadwidget.ui <span style="color: grey">(17f2944e81c0510eb7ae85128e79e815eab1bf54)</span></li>
<li>tier3/knewstuff/src/downloadwidget_p.h <span style="color: grey">(080e1779e0d2ed110da28cc087218262fad1f333)</span></li>
<li>tier3/knewstuff/src/entry_p.h <span style="color: grey">(73c1ee8619b171f90706ba3ed323abbd00add455)</span></li>
<li>tier3/knewstuff/src/staticxml/staticxmlprovider.h <span style="color: grey">(52caed08f53d125928d12f329c96800530d9fcaa)</span></li>
<li>tier3/knewstuff/src/staticxml/staticxmlprovider.cpp <span style="color: grey">(e7dd0686f122c938cf87959478acc97a0a25723b)</span></li>
<li>tier3/knewstuff/src/ui/entrydetailsdialog.h <span style="color: grey">(0add71dfecd4f0cb8653e9a90568bad5d9d2e008)</span></li>
<li>tier3/knewstuff/src/ui/entrydetailsdialog.cpp <span style="color: grey">(5a451086531c53af720a2874f5c3b5ed51d07423)</span></li>
<li>tier3/knewstuff/src/ui/imageloader.h <span style="color: grey">(5e87a7b7890b6678c4b94aacc1b2f84d001b7dd0)</span></li>
<li>tier3/knewstuff/src/ui/imageloader.cpp <span style="color: grey">(8e6ed061e421e985535228599ff9da17303bae46)</span></li>
<li>tier3/knewstuff/src/ui/imagepreviewwidget.h <span style="color: grey">()</span></li>
<li>tier3/knewstuff/src/ui/imagepreviewwidget.cpp <span style="color: grey">(d9d20775a9686715176ead2f24f122d82b88987b)</span></li>
<li>tier3/knewstuff/src/ui/itemsgridviewdelegate.h <span style="color: grey">(a5d793d8c859c25639921cc9a05233cb9879377e)</span></li>
<li>tier3/knewstuff/src/ui/itemsgridviewdelegate.cpp <span style="color: grey">(3970287927e8c17acc9347adbae4c342c78d389a)</span></li>
<li>tier3/knewstuff/src/ui/itemsmodel.h <span style="color: grey">(7bc691483b3f0a27dc0d35a7fa6a4ad877294c1a)</span></li>
<li>tier3/knewstuff/src/ui/itemsmodel.cpp <span style="color: grey">(d972c53f2963dba4ed55bfb484005b77b056c323)</span></li>
<li>tier3/knewstuff/src/ui/itemsview.h <span style="color: grey">()</span></li>
<li>tier3/knewstuff/src/ui/itemsview.cpp <span style="color: grey">(b200b651bf1c57b37c7d8cb8163246488e6b17fb)</span></li>
<li>tier3/knewstuff/src/ui/itemsviewbasedelegate.h <span style="color: grey">(bbb08dbc1755b9d9c5bde20c27e7bf368c149c29)</span></li>
<li>tier3/knewstuff/src/ui/itemsviewbasedelegate.cpp <span style="color: grey">(89e91f9563f95985759388dcfca76d480a9dedba)</span></li>
<li>tier3/knewstuff/src/ui/itemsviewdelegate.h <span style="color: grey">(1df97a36fc72d9eb3b2d07c5edff0170db459ea5)</span></li>
<li>tier3/knewstuff/src/ui/itemsviewdelegate.cpp <span style="color: grey">(5289ee0093e7e4d02e6250bad8807f7c7e0d04c7)</span></li>
<li>tier3/knewstuff/src/ui/progressindicator.h <span style="color: grey">()</span></li>
<li>tier3/knewstuff/src/ui/progressindicator.cpp <span style="color: grey">(ab06ff19c103c4d809d9ef4b14586bcd936e75c5)</span></li>
<li>tier3/knewstuff/src/upload/atticahelper.h <span style="color: grey">()</span></li>
<li>tier3/knewstuff/src/upload/atticahelper.cpp <span style="color: grey">(c17b743c29943fbd25020dc9c8b7a0862cdc2458)</span></li>
<li>tier3/knewstuff/src/uploaddialog_p.h <span style="color: grey">(084d626c095465b5176aa928fed1d6d6342e6e2d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113696/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>