<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113712/">http://git.reviewboard.kde.org/r/113712/</a>
     </td>
    </tr>
   </table>
   <br />











<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/113712/diff/1/?file=211813#file211813line22" style="color: black; font-weight: bold; text-decoration: underline;">tier2/knotifications/tests/CMakeLists.txt</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">   <span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kpassivepopuptest</span> <span class="o">${</span><span class="nv">X11_X11_LIB</span><span class="o">}</span> <span class="s">Qt5::X11Extras</span> <span class="s">KF5::KWindowSystem</span><span class="p">)</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">do you need to link XLib? From the code changes you did it looks like you don't use any XLib call at all.</pre>
</div>
<br />



<p>- Martin Gräßlin</p>


<br />
<p>On November 7th, 2013, 8:03 p.m. CET, Alex Merry wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>


<p style="color: grey;"><i>Updated Nov. 7, 2013, 8:03 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add popup for window with SkipTaskbar set in kpassivepopuptest

KPassivePopup should place this next to the window itself.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, runs, new test does the right thing.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tier2/knotifications/tests/kpassivepopuptest.cpp <span style="color: grey">(266842aa336793248663a15e19d4ba22c32ee412)</span></li>

 <li>tier2/knotifications/tests/kpassivepopuptest.h <span style="color: grey">(c9620b975295be6d59b974824d1cb4e08c860f6f)</span></li>

 <li>tier2/knotifications/tests/CMakeLists.txt <span style="color: grey">(ce87f1752856dcc0b37ef86fb3bfdbdaf4ef5685)</span></li>

 <li>tier2/knotifications/src/CMakeLists.txt <span style="color: grey">(cf312e028c323521504bd9ccd4c8f3f817e13497)</span></li>

 <li>tier2/knotifications/CMakeLists.txt <span style="color: grey">(6df0022536436477cc9cd875e0bccd70e78d32d3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113712/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>