<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113711/">http://git.reviewboard.kde.org/r/113711/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KPassivePopup had a bunch of odd public API that no-one was using because it's useless to outside classes (even subclasses, of which there appear to be none). This hides that away, and makes the protected stuff actually useful.
There are still some issues with the "next to the taskbar" positioning (it puts it alongside the entry instead of on the opposite side the screen edge), but that's less urgent than the API change.
Clean up API of KPassivePopup
Firstly, allow subclasses to more easily override the location:
* remove defaultArea from the public API, as it is useless to clients
* replace it with a virtual protected method defaultLocation
Secondly, move other methods that should be private to the Private
class.
Thirdly, remove the Custom entry from the PopupStyle enum as there is,
in practice, no easy way for subclasses to implement another style; by
the time they do, they may as well start from scratch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still builds, test app still puts the popups where expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier2/knotifications/src/kpassivepopup.h <span style="color: grey">(4eb6ffc7b076391d3f74ce902cc964371b1046c8)</span></li>
<li>tier2/knotifications/src/kpassivepopup.cpp <span style="color: grey">(f17086d3185e207b874f4dcfecf1da8715a3fd77)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113711/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>