<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113657/">http://git.reviewboard.kde.org/r/113657/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 7th, 2013, 9:21 a.m. UTC, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's going in the right direction, but I am wondering whether the Find*.cmake files should go to extra-cmake-modules instead of being part of the framework. You should add Steve (skelly) to the review to get his opinion.</pre>
</blockquote>
<p>On November 7th, 2013, 11:10 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, the idea was to have them all in extra-cmake-modules.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm adding both ervin and skelly to the review because of this comment a couple of meetings ago:
[Tuesday, October 29, 2013] [11:43:21 AM] <ervin> depends if that's the only framework using them and they are not interesting to the outside, keeping them in a cmake/ folder is ok, but they shouldn't be installed in that case</pre>
<br />
<p>- David</p>
<br />
<p>On November 7th, 2013, 1:30 p.m. UTC, David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Kevin Ottens, Aurélien Gâteau, and Stephen Kelly.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2013, 1:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when building with DNSSD and factored out the Frameworks version.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Configure with cmake
2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1
Configures OK in both cases. Builds OK in case 1, does not build yet in case 2.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/CMakeLists.txt <span style="color: grey">(7910270)</span></li>
<li>cmake/modules/FindAvahi.cmake <span style="color: grey">()</span></li>
<li>cmake/modules/FindDNSSD.cmake <span style="color: grey">(8604bd5)</span></li>
<li>tier2/dnssd/CMakeLists.txt <span style="color: grey">(2cfcc40)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113657/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>