<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113650/">http://git.reviewboard.kde.org/r/113650/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2013, 1:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">add alex and steveire to the review, in case they didn't get it.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Generate the forward headers using the macro instead of crafting it into a loop.
Install the CamelCase headers in prefix/includes/KParts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built, everything installed ok.
Installed files:
kde-devel@thinktatil:~/build-frameworks/kdelibs$ cat install_manifest.txt | grep include | grep -i kparts
/home/kde-devel/kde5/include/kparts_version.h
/home/kde-devel/kde5/include/KParts/ListingExtension
/home/kde-devel/kde5/include/KParts/PartManager
/home/kde-devel/kde5/include/KParts/TextExtension
/home/kde-devel/kde5/include/KParts/ScriptableExtension
/home/kde-devel/kde5/include/KParts/HistoryProvider
/home/kde-devel/kde5/include/KParts/BrowserExtension
/home/kde-devel/kde5/include/KParts/BrowserInterface
/home/kde-devel/kde5/include/KParts/MainWindow
/home/kde-devel/kde5/include/KParts/BrowserOpenOrSaveQuestion
/home/kde-devel/kde5/include/KParts/Event
/home/kde-devel/kde5/include/KParts/BrowserRun
/home/kde-devel/kde5/include/KParts/HtmlExtension
/home/kde-devel/kde5/include/KParts/FileInfoExtension
/home/kde-devel/kde5/include/KParts/StatusBarExtension
/home/kde-devel/kde5/include/KParts/Part
/home/kde-devel/kde5/include/KParts/Plugin
/home/kde-devel/kde5/include/kparts/kparts_export.h
/home/kde-devel/kde5/include/kparts/part.h
/home/kde-devel/kde5/include/kparts/plugin.h
/home/kde-devel/kde5/include/kparts/partmanager.h
/home/kde-devel/kde5/include/kparts/mainwindow.h
/home/kde-devel/kde5/include/kparts/event.h
/home/kde-devel/kde5/include/kparts/browserextension.h
/home/kde-devel/kde5/include/kparts/historyprovider.h
/home/kde-devel/kde5/include/kparts/browserinterface.h
/home/kde-devel/kde5/include/kparts/browserrun.h
/home/kde-devel/kde5/include/kparts/statusbarextension.h
/home/kde-devel/kde5/include/kparts/browseropenorsavequestion.h
/home/kde-devel/kde5/include/kparts/scriptableextension.h
/home/kde-devel/kde5/include/kparts/textextension.h
/home/kde-devel/kde5/include/kparts/htmlextension.h
/home/kde-devel/kde5/include/kparts/fileinfoextension.h
/home/kde-devel/kde5/include/kparts/listingextension.h
/home/kde-devel/kde5/include/kparts/componentfactory.h
/home/kde-devel/kde5/include/kparts/genericfactory.h
/home/kde-devel/kde5/include/kparts/factory.h
/home/kde-devel/kde5/include/KDE/KParts/BrowserExtension
/home/kde-devel/kde5/include/KDE/KParts/BrowserHostExtension
/home/kde-devel/kde5/include/KDE/KParts/BrowserInterface
/home/kde-devel/kde5/include/KDE/KParts/BrowserRun
/home/kde-devel/kde5/include/KDE/KParts/ComponentFactory
/home/kde-devel/kde5/include/KDE/KParts/DockMainWindow3
/home/kde-devel/kde5/include/KDE/KParts/Event
/home/kde-devel/kde5/include/KDE/KParts/Factory
/home/kde-devel/kde5/include/KDE/KParts/FileInfoExtension
/home/kde-devel/kde5/include/KDE/KParts/GUIActivateEvent
/home/kde-devel/kde5/include/KDE/KParts/GenericFactory
/home/kde-devel/kde5/include/KDE/KParts/GenericFactoryBase
/home/kde-devel/kde5/include/KDE/KParts/HistoryProvider
/home/kde-devel/kde5/include/KDE/KParts/HtmlExtension
/home/kde-devel/kde5/include/KDE/KParts/LiveConnectExtension
/home/kde-devel/kde5/include/KDE/KParts/ListingExtension
/home/kde-devel/kde5/include/KDE/KParts/MainWindow
/home/kde-devel/kde5/include/KDE/KParts/OpenUrlEvent
/home/kde-devel/kde5/include/KDE/KParts/Part
/home/kde-devel/kde5/include/KDE/KParts/PartActivateEvent
/home/kde-devel/kde5/include/KDE/KParts/PartBase
/home/kde-devel/kde5/include/KDE/KParts/PartManager
/home/kde-devel/kde5/include/KDE/KParts/PartSelectEvent
/home/kde-devel/kde5/include/KDE/KParts/Plugin
/home/kde-devel/kde5/include/KDE/KParts/ReadOnlyPart
/home/kde-devel/kde5/include/KDE/KParts/ReadWritePart
/home/kde-devel/kde5/include/KDE/KParts/StatusBarExtension
/home/kde-devel/kde5/include/KDE/KParts/TextExtension
/home/kde-devel/kde5/include/KDE/KParts/WindowArgs</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier3/kparts/src/CMakeLists.txt <span style="color: grey">(4c3de10)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113650/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>