<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113527/">http://git.reviewboard.kde.org/r/113527/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me, would need someone with more X knowledge to look at it.</pre>
<br />
<p>- Kevin Ottens</p>
<br />
<p>On November 4th, 2013, 10:17 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2013, 10:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alternative to RR 113393.
Commit 1: Move KPassivePopup to KNotifications
As well as being a conceptual fit, KPassivePopup needs to do X11 magic,
and this is a lot easier if it can make use of the KWindowSystem
library.
Commit 2: Fix KPassivePopup placement
The non-X11 code is largely untested.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Test app (in tests/ folder) works as expected on X11: if _NET_WM_ICON_GEOMETRY is set and a window id is passed, the popup is placed by the taskbar entry; if it is not set, it is place by the window; if a window id is not passed, it is placed top left (avoiding any panels) on the desktop.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kwidgetsaddons/CMakeLists.txt <span style="color: grey">(01bae90e235fae424f3af48fb95dc24286e60562)</span></li>
<li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(beb5ecad9e063936dea9ca38f42238988ca3f51b)</span></li>
<li>tier1/kwidgetsaddons/src/kpassivepopup.h <span style="color: grey">(d7cef3dd94713554010547001de6b4d81e3e2961)</span></li>
<li>tier1/kwidgetsaddons/src/kpassivepopup.cpp <span style="color: grey">(663f63af413b7660c9c1b21af3e3ae4d7c424bbe)</span></li>
<li>tier1/kwidgetsaddons/tests/CMakeLists.txt <span style="color: grey">(d0140ea2489a629949b7022f310dcd6349c06f20)</span></li>
<li>tier1/kwidgetsaddons/tests/kpassivepopuptest.h <span style="color: grey">()</span></li>
<li>tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp <span style="color: grey">(4e7138523bdbe4166bf0e899d39d9ae1f8b8b447)</span></li>
<li>tier2/knotifications/src/CMakeLists.txt <span style="color: grey">(7f5a332d6650f998d72c97b7cfddd27362756b08)</span></li>
<li>tier2/knotifications/tests/CMakeLists.txt <span style="color: grey">(6f3be50819ffef19644b77c397e5b4966d61abd6)</span></li>
<li>tier4/kde4support/tests/CMakeLists.txt <span style="color: grey">(b22e2e818fc13519318fa32de44f5d4a32301661)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113527/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>