<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113536/">http://git.reviewboard.kde.org/r/113536/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3fc2059cfc863b5b99c63105e4761d9daa78c3a9 by Alex Merry to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On November 2nd, 2013, 2:32 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2013, 2:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A whole bunch of commits (listed below in reverse order, like git log). This is a preliminary to actually fixing up some of the plugins (like the EPS one).
Also, I intend to run astyle on the directory, which is a horrible mess of different styles (even within the same file). But that's not included in this request, since it would make the diff fairly useless.
Remove the unhelpful ChangeLog
Improve README file
Mostly remove the list of plugins, since that is the sort of information
that will not be kept in sync.
Remove uppercase keys from imageformat json files
QImageReader/Writer lowercases image formats before searching for
plugins, so uppercase keys are useless.
Add desktop file for WBMP plugin
This is provided by the qtimageformats module
Do not install desktop files for imageformat plugins that are not built
If missing libraries etc. mean we do not build a plugin, we should not
install the desktop file for it.
Add imageconverter app to test imageformat plugins
It is a command-line utility that converts images from one format to
another using QImageReader and QImageWriter.
Move kguiaddons/src/plugins to kguiaddons/src/plugins/imageformats
This allows the plugins to be used prior to installation (for example,
by tests) by adding kguiaddons/src/plugins to Qt's search path.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The new imageconverter test utility works (and uses the locally-built plugins before any installed ones).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kguiaddons/src/CMakeLists.txt <span style="color: grey">(e1b17f4fcbda1052e21303f61f313058a9190da5)</span></li>
<li>tier1/kguiaddons/src/plugins/AUTHORS <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/CMakeLists.txt <span style="color: grey">(0536abeddb40220626be2ca80bf68c4a5cf79351)</span></li>
<li>tier1/kguiaddons/src/plugins/ChangeLog <span style="color: grey">(3d9f6dc1463d628db8a9f8fadab18475cd15160e)</span></li>
<li>tier1/kguiaddons/src/plugins/Mainpage.dox <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/README <span style="color: grey">(20f3ef0019b571947d390cecdadcdd4745e4fe28)</span></li>
<li>tier1/kguiaddons/src/plugins/bmp.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/config-kimgio.h.cmake <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/dds.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/dds.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/dds.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/dds.json <span style="color: grey">(38b3d9adb13ab959d53190b218f083ed02f7d0eb)</span></li>
<li>tier1/kguiaddons/src/plugins/eps.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/eps.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/eps.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/eps.json <span style="color: grey">(225c2895efecec14f09e1d5bd1f115aaee6eb0a0)</span></li>
<li>tier1/kguiaddons/src/plugins/exr.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/exr.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/exr.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/exr.json <span style="color: grey">(26fb4978de5d69ea4a8c10939f1b7ac026a63d0f)</span></li>
<li>tier1/kguiaddons/src/plugins/g3r.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/g3r.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/gif.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/gimp.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/hdr.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/hdr.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/hdr.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/ico.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/imageformats/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kguiaddons/src/plugins/imageformats/eps.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kguiaddons/src/plugins/imageformats/rgb.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kguiaddons/src/plugins/imageformats/wbmp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kguiaddons/src/plugins/imageformats/xview.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kguiaddons/src/plugins/jp2.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/jp2.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/jp2.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/jp2.json <span style="color: grey">(5a92b36c58e3852f71493b6fe5db8b271b9f8513)</span></li>
<li>tier1/kguiaddons/src/plugins/jpeg.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/mng.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/pbm.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/pcx.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/pcx.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/pcx.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/pcx.json <span style="color: grey">(b3a7fc97fcb43eda91e90278af71b71b5f1066a6)</span></li>
<li>tier1/kguiaddons/src/plugins/pgm.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/pic.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/pic.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/pic.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/pic.json <span style="color: grey">(68f6f37ad08f3a0b3199240f5a135806a2b8ef46)</span></li>
<li>tier1/kguiaddons/src/plugins/pic_read.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/pic_rw.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/pic_write.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/png.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/pnm.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/ppm.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/psd.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/psd.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/psd.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/psd.json <span style="color: grey">(da33c688c0a2a75cdbe24637ca8fd4ae1ffe807f)</span></li>
<li>tier1/kguiaddons/src/plugins/qimageio_plugin.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/ras.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/ras.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/ras.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/ras.json <span style="color: grey">(7ba02f4b8ad446cedc730d2a721c042a835b864d)</span></li>
<li>tier1/kguiaddons/src/plugins/rgb.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/rgb.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/rgb.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/rgb.json <span style="color: grey">(876ce9c6b56389599ed94d08bc4d130d208cdfd5)</span></li>
<li>tier1/kguiaddons/src/plugins/svg+xml-compressed.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/svg+xml.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/tga.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/tga.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/tga.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/tga.json <span style="color: grey">(984d56e0b9508cb0e8383459a53060999637ffd2)</span></li>
<li>tier1/kguiaddons/src/plugins/tiff.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/xbm.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/xcf.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/xcf.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/xcf.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/xcf.json <span style="color: grey">(da38a243cdf66c524e357fdbc19aafd0caecf764)</span></li>
<li>tier1/kguiaddons/src/plugins/xpm.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/xv.desktop <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/xview.h <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/xview.cpp <span style="color: grey">()</span></li>
<li>tier1/kguiaddons/src/plugins/xview.json <span style="color: grey">(4765c68cc81ae6434936f4e280e1d652d9971de1)</span></li>
<li>tier1/kguiaddons/tests/CMakeLists.txt <span style="color: grey">(754b460e253c8856686ae442e4587c2ee57bb714)</span></li>
<li>tier1/kguiaddons/tests/imageconverter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113536/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>