<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113586/">http://git.reviewboard.kde.org/r/113586/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 7d21b11b3cbb464e4ef9477157e84a411df59fd4 by Alex Merry to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On November 3rd, 2013, 5:24 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2013, 5:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined.
Remove call to KUrlRequester::fileDialog() from test
This is (a) unnecessary and (b) deprecated.
KIO::RenameDialog: use KIO::suggestName instead of local method
Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED,
like its declaration.
Remove use of deprecated form of KRecentDocument::add
KCategoryDrawerV3 -> KCategoryDrawer in KPluginSelector
Mark KPluginInfo::fromServices as deprecated
It is simply the multiple-at-once version of the deprecated KPluginInfo
constructor that takes a KService.
Mark unused (except for debugging) args with Q_UNUSED
Wrap test of deprecated method in KDE_NO_DEPRECATED
The test will not compile with KDE_NO_DEPRECATED set...
Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set
It calls a deprecated method, and its declaration is wrapped in
KDE_NO_DEPRECATED as well.
KAuth: handle QtTraceMsg messages
We just treat them like debug messages.
Fix warnings in Solid UDisks2 backend
Make it explicit that UDisks2 does not support Keyboard or
PointingDevice. Also make the switch statement easier to read.
Wrap assertion function in #ifndef QT_NO_DEBUG
This function is only used in a Q_ASSERT, so prevent it from being
compiled if assertions are disabled.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds; tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kio/src/filewidgets/kencodingfiledialog.cpp <span style="color: grey">(c6c159fb016b8b8b1a7caa20d814f62e1989bb57)</span></li>
<li>staging/kio/src/filewidgets/kfilewidget.cpp <span style="color: grey">(48215315ea1a4c335992185735b8a717b8d5add6)</span></li>
<li>staging/kio/src/widgets/renamedialog.cpp <span style="color: grey">(0830c90a199a780e79966d3220e595866c8f7b96)</span></li>
<li>staging/kio/tests/kurlrequestertest_gui.cpp <span style="color: grey">(948085f090e3c388246ae7b11ae348a089a5893c)</span></li>
<li>tier1/itemmodels/src/kselectionproxymodel.cpp <span style="color: grey">(df83ae6c51edcdf01d1d16b351a63507d6a5a982)</span></li>
<li>tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h <span style="color: grey">(43a1b6f896834e9fe9e94e9580ff5845036aa754)</span></li>
<li>tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp <span style="color: grey">(ee44d930eddd647e8ad5d1cf20097a1b8a719efa)</span></li>
<li>tier2/kauth/src/kauthhelpersupport.cpp <span style="color: grey">(8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb)</span></li>
<li>tier2/kcompletion/src/kcombobox.cpp <span style="color: grey">(4043ea5448a67c01751cc849d56c3fdd4d61035c)</span></li>
<li>tier2/kcompletion/tests/klineedittest.cpp <span style="color: grey">(233bdd3afd8b489e9f32f81ac89b57114948c034)</span></li>
<li>tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp <span style="color: grey">(dfd2a6d83c637215219c7fd928dcd4fb37097ddf)</span></li>
<li>tier3/kservice/src/services/kplugininfo.h <span style="color: grey">(2555ef27d1ccc2fa58a905175bdcefab4e6491ea)</span></li>
<li>tier3/kservice/src/services/kplugininfo.cpp <span style="color: grey">(e19ae7e3fcadfbcadfcecea3795a0d9afad09753)</span></li>
<li>tier3/xmlgui/src/kxmlguifactory.cpp <span style="color: grey">(d2980f45fe8e32f1b4aa535661eb002c69969698)</span></li>
<li>tier4/kcmutils/src/kpluginselector.cpp <span style="color: grey">(768dbf33b136b79f3cab4c6f09e84d2a4378a022)</span></li>
<li>tier4/kcmutils/src/kpluginselector_p.h <span style="color: grey">(de42f03a99ba35e4c43927a7e2c07fc3a541de5a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113586/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>