<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113507/">http://git.reviewboard.kde.org/r/113507/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 1f26a9f27ea69b074c7d4afad6b4692d6988afdb by Alex Richardson to branch frameworks.</pre>
 <br />









<p>- Commit Hook</p>


<br />
<p>On October 30th, 2013, 3:59 p.m. UTC, Alexander Richardson wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>


<p style="color: grey;"><i>Updated Oct. 30, 2013, 3:59 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use ecm_mark_as_test for test-only targets</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles + installs</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kio/httpfilter/autotests/CMakeLists.txt <span style="color: grey">(2ae8fddf795bb14ca99be1734dada330bcf2c58a)</span></li>

 <li>kioslave/http/kcookiejar/tests/CMakeLists.txt <span style="color: grey">(d929b28dca8755613ba1cd071e400aeff7c1ea8c)</span></li>

 <li>kioslave/http/tests/CMakeLists.txt <span style="color: grey">(294c42ae6f5eb7af56c888d120ba804c0e3b36f2)</span></li>

 <li>tier1/karchive/autotests/CMakeLists.txt <span style="color: grey">(af6e8b3a438590fe933d538200cebca056086da2)</span></li>

 <li>tier1/kdbusaddons/tests/CMakeLists.txt <span style="color: grey">(65a65bfce32976d79f0234a0181b0fe9cbb7357f)</span></li>

 <li>tier1/kjs/autotests/CMakeLists.txt <span style="color: grey">(7ea499439cf9fe32180baf9a89f33517ea806d95)</span></li>

 <li>tier2/kauth/autotests/CMakeLists.txt <span style="color: grey">(90e6d77be3d71827b4ac13b89fb39212e3db1d39)</span></li>

 <li>tier3/kbookmarks/autotests/CMakeLists.txt <span style="color: grey">(c0a67db787db3f426d172270d00a0d3f08554575)</span></li>

 <li>tier3/kservice/autotests/CMakeLists.txt <span style="color: grey">(c656d441dc641dea5106ba725bdb34af940af33f)</span></li>

 <li>tier3/xmlgui/tests/krichtexteditor/CMakeLists.txt <span style="color: grey">(308c28f5ec2d59c63f08401b3ffb42c28f74829f)</span></li>

 <li>tier4/kde4support/autotests/CMakeLists.txt <span style="color: grey">(a850e8db69871e61a0699a8807c84adc18303a25)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113507/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>