<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113426/">http://git.reviewboard.kde.org/r/113426/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 89d2b298dfe4b97b2e51d55bb85f96a1e803714e by David Gil to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On October 24th, 2013, 9:54 p.m. UTC, David Gil Oliva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Gil Oliva.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2013, 9:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adjust API in KEmoticons framework: createNew method
-To make KEmoticons API more consistent, deprecate KEmoticonsProvider::createNew()
and prefer newTheme() instead, as it appears in KEmoticonsTheme. That way,
we have loadTheme(), saveTheme() and newTheme().
-Adjust plugins.
-Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::createNew(),
which was empty. Therefore, I deprecate it and advice subclassing
KEmoticonsProvider.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds. Tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDE5PORTING.html <span style="color: grey">(ceff2fa13e4a666939dd0a1bb63e967504c31c07)</span></li>
<li>staging/kemoticons/src/core/kemoticons.cpp <span style="color: grey">(43dac6517b77a0d0040912958fe76687b475d85c)</span></li>
<li>staging/kemoticons/src/core/kemoticonsprovider.h <span style="color: grey">(2ec0de8d1dfb846188bd458b49a4028fee115431)</span></li>
<li>staging/kemoticons/src/core/kemoticonsprovider.cpp <span style="color: grey">(7374966c65922c3e7a5be881c198a8f8f52fee29)</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.h <span style="color: grey">(25fc29453535d7e73f4e2d0752ce3f989c83fa96)</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.cpp <span style="color: grey">(e54d015e7f0f866d199d8eed7863fafd28576c13)</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.h <span style="color: grey">(01d89e13834c345765e696d66560071dc10291af)</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.cpp <span style="color: grey">(e6719d112a14478bdfd7f8c47633c18108a5633a)</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.h <span style="color: grey">(0738b79dcf734b7904e061b5eb41807ccaf443ff)</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.cpp <span style="color: grey">(a99c6d84f5ab7e0e2f41027c37a97f170333dca8)</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h <span style="color: grey">(a51b736f7702d7af1f1367dd1f13271647212fee)</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp <span style="color: grey">(7596e30e8e5153185a3dd365858567c69477ff4a)</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h <span style="color: grey">(4ba706f519cebedaa6c9c3f2f02331e85745e89a)</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp <span style="color: grey">(afb07b207407b00bbe0d38e0ca6d9e2bf2ccd809)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113426/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>