<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113430/">http://git.reviewboard.kde.org/r/113430/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 2e3cf98a87484946948962acd66a5fff269b5a51 by Alex Merry to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On October 25th, 2013, 2:08 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2013, 2:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a series of commits:
warnings--: parentheses around '&&' within '||'
Fix a couple of warnings inadventently caused by 139a09da
Use a better hack for dealing with gperf's unhelpful inlining
gperf (in ANSI-C mode) attempts to inline functions in gnu90 mode, which
*only* generates inline versions. This causes linker errors if the
compiler decides not to use inlining.
Previously, there was a hack (claiming to prevent warnings) that
disabled __inline keyword, which fixed the linking issue but caused
another warning (about ignored attributes) to be emitted because the
__gnu_inline__ attribute was still there, and that doesn't work without
one of the normal inline keywords.
This version leaves __inline alone, but prevents the use of
__gnu_inline__.
Use KHTML_NO_EXPORT on the decl (not def) of tagPriorityArray
Visibility attributes only work on declarations, not on definitions.
Remove virtual modifier from signal
A virtual signal makes no sense.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/src/html/dtd.cpp <span style="color: grey">(9cfa345af618861a9b8ddf9a93dd180c9a15c6d7)</span></li>
<li>khtml/src/html/dtd.h <span style="color: grey">(1e04e58b356c5d0ece23f8fc78cffdc6cf64817c)</span></li>
<li>khtml/src/css/parser.y <span style="color: grey">(e24d5f46e27c686fa855feee27dbe2dbf39108cb)</span></li>
<li>khtml/src/html/htmlparser.cpp <span style="color: grey">(6c23dd5b5a2a1e567adc8cfa0233e10838cf3451)</span></li>
<li>khtml/src/rendering/render_canvasimage.cpp <span style="color: grey">(346a65491e459c3d8f1c731340ff5a6ae33b35f1)</span></li>
<li>khtml/src/rendering/render_inline.cpp <span style="color: grey">(84e07eab5604e4882fd816826b6e59c317c53805)</span></li>
<li>tier1/itemmodels/src/kselectionproxymodel.cpp <span style="color: grey">(c7ded3f8c54eba0afa1974ddb67972eddf7d7f1a)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevbutton.h <span style="color: grey">(39eb6683fc611dfff5b6fef69e66ab709238e889)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113430/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>