<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113393/">http://git.reviewboard.kde.org/r/113393/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 29th, 2013, 8:09 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wouldn't moving this class in KNotifications and from there use KWindowSystem be a better fix then?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That would certainly be the easiest way to get a correct implementation, and it would fit conceptually. The only downside I see is that KPassivePopup acts as a kind of "lightweight" notification mechanism: putting it in KNotifications would prevent anyone from getting the "lightweight" KPassivePopup without also getting the "heavyweight" knotification system.
Either way, I think these changes should be useful for non-X11 systems. But I can do them as part of a "move to knotifications an implement properly" thing as well.</pre>
<br />
<p>- Alex</p>
<br />
<p>On October 22nd, 2013, 9:21 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2013, 9:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Get KPassivePopup positioning in a semi-working state
Since we cannot use the NETWM stuff from KWindowSystems, we are forced
to either rely on what Qt can give us or hack in window-system-specific
code. This does the former, using QDesktopWidget to calculate the
default placement of the popup, QWidget to place the popup next to our
own windows and QWindow for foreign windows.
Caveats:
* the docs claim the popup will be placed next to taskbar entries; this
is not possible using only what Qt gives us
* Qt does not provide foreign window geometry on X11, so if you pass a
foreign window id you will just get the default placement</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds. Test application seems to work as expected (on X11, at least).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kwidgetsaddons/CMakeLists.txt <span style="color: grey">(ea6654d83acb265a87ed21c913a7f799b457ca71)</span></li>
<li>tier1/kwidgetsaddons/src/kpassivepopup.cpp <span style="color: grey">(663f63af413b7660c9c1b21af3e3ae4d7c424bbe)</span></li>
<li>tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp <span style="color: grey">(4e7138523bdbe4166bf0e899d39d9ae1f8b8b447)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113393/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>