<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113370/">http://git.reviewboard.kde.org/r/113370/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113370/diff/2/?file=206414#file206414line42" style="color: black; font-weight: bold; text-decoration: underline;">tier3/kded/src/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">15</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KF5::KService</span> <span class="c"># Needed for ksycoca.h, should be replaced with KF5::KService</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this comment is still wrong</pre>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On October 29th, 2013, 1:10 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2013, 1:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moves KDED to tier3.
I have removed any use of X11/Properties used to communicate with KSplash since we want to use either DBus or Wayland but certainly not X11.
I plan to work on session startup in a few weeks so I will fix (if nobody else does before me) KSplash <---> KDED communication by then.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(6afb8e6)</span></li>
<li>kded/CMakeLists.txt <span style="color: grey">(a06ed09)</span></li>
<li>kded/DESIGN <span style="color: grey">()</span></li>
<li>kded/HOWTO <span style="color: grey">()</span></li>
<li>kded/Info.plist.template <span style="color: grey">()</span></li>
<li>kded/Mainpage.dox <span style="color: grey">()</span></li>
<li>kded/README.kded <span style="color: grey">(05fec85)</span></li>
<li>kded/config-kded.h.cmake <span style="color: grey">(21210ab)</span></li>
<li>kded/kded.h <span style="color: grey">()</span></li>
<li>kded/kded.cpp <span style="color: grey">(aab548b)</span></li>
<li>kded/kdedadaptor.h <span style="color: grey">()</span></li>
<li>kded/kdedadaptor.cpp <span style="color: grey">()</span></li>
<li>kded/kdedmodule.desktop <span style="color: grey">()</span></li>
<li>kded/org.kde.kded5.service.in <span style="color: grey">()</span></li>
<li>kioslave/http/kcookiejar/CMakeLists.txt <span style="color: grey">(8d61c01)</span></li>
<li>tier3/CMakeLists.txt <span style="color: grey">(249a60b)</span></li>
<li>tier3/kded/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kded/KDEDConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113370/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>