<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113395/">http://git.reviewboard.kde.org/r/113395/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 23rd, 2013, 1:25 a.m. UTC, <b>Andrius da Costa Ribas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113395/diff/1/?file=204894#file204894line425" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kconfig/src/core/kconfigini.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KConfigIniBackend::writeConfig(const QByteArray& locale, KEntryMap& entryMap,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">425</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//</span><span class="cs">TODO</span><span class="c1">: getuid does not exist on windows, use a different solution?</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Files have no owner on Windows. QFileInfo::ownerId() always returns -2 on Windows and so would do kdewin's getuid, so here we probably should follow the "if" part, not the "else" one.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops. Double comment ... I thought the first one hadn't been saved ;)</pre>
<br />
<p>- Andrius da Costa</p>
<br />
<p>On October 23rd, 2013, 12:03 a.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2013, 12:03 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KConfig now also compiles on Windows
the qt3support function QDir::convertSeparators no longer exists
remove dependency on unistd.h on Windows
fix linking of KSharedConfig on MSVC2012
Without disabling the copy constructor we get an undefined referece to
KConfig::KConfig(const KConfig&)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a series of 4 small commits as one patch. I can squash them into one commit if that is preferred.
Everything compiles with VS2012 (64 bit). To get kconfig_compiler to generate the tests I had to add the Qt 5.2 beta binaries dir to PATH since that contains QtCore.dll, etc.
Test don't work due to Windows lacking rpath or LD_LIBRARY_PATH, i.e. the necessary libraries are not found.
I see two possible solutions:
-CMake sets $PATH to include the needed libraries (have to make sure the newly compiled ones are before the installed ones)
-A wrapper executable sets the DLL search paths and then launches the tests
I don't have the time to solve that problem now, if anyone does:
http://msdn.microsoft.com/en-us/library/windows/desktop/ms682586%28v=vs.85%29.aspx
http://msdn.microsoft.com/en-us/library/windows/desktop/ms686203%28v=vs.85%29.aspx
http://msdn.microsoft.com/en-us/library/windows/desktop/hh310513%28v=vs.85%29.aspx
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/CMakeLists.txt <span style="color: grey">(bc5bdaa46414c6c449920f38b0e16cdd1d9d1b9a)</span></li>
<li>tier1/kconfig/CMakeLists.txt <span style="color: grey">(4cebdf010c73baf5381e9601072a59ba3f1c0a9f)</span></li>
<li>tier1/kconfig/autotests/kconfigtest.cpp <span style="color: grey">(022809e9b9ec700206d472ed4cfa5ed82058bc34)</span></li>
<li>tier1/kconfig/src/core/kauthorized.cpp <span style="color: grey">(c814b729dc9b6e9efd9b3922fa02249abf460989)</span></li>
<li>tier1/kconfig/src/core/kconfig.cpp <span style="color: grey">(2d5f4897f2bee8c881205ec3e0ef20f5d9d03564)</span></li>
<li>tier1/kconfig/src/core/kconfiggroup.cpp <span style="color: grey">(b42ca12e02af1cf173cee97d338cc895b4c822ed)</span></li>
<li>tier1/kconfig/src/core/kconfigini.cpp <span style="color: grey">(5a7702a76f70d97fe48de8bb16f2a052e993d907)</span></li>
<li>tier1/kconfig/src/core/kdesktopfile.cpp <span style="color: grey">(7518994ac7a72dc782d9df394e5b466a0cbac5fc)</span></li>
<li>tier1/kconfig/src/core/ksharedconfig.h <span style="color: grey">(b461999b29a6c966c6a8734b316dbbee11ecdc6c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113395/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>