<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113391/">http://git.reviewboard.kde.org/r/113391/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove unnecessary #includes for moc files
These are all of the form #include "foo.moc", which tells automoc to
process foo.cpp, but where there is no class (Q_OBJECT-tagged) in the
.cpp file for moc to process.
This gets rid of nearly all the messages about appropriate files not
being found to process (except in the kconfig_compiler tests, where
the code is autogenerated).
The ThreadWeaver cleanup is more extensive, because it had more qmake compatibility hacks (which I don't think are needed any more; they seem out of date, at least, and there are no .pro files).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/src/java/kjavaappletcontext.cpp <span style="color: grey">(7721cc3524d1e6fee3ffce89214a2620e5dfec8a)</span></li>
<li>khtml/src/khtml_iface.cpp <span style="color: grey">(cc60a58bbe199cc47c62502bdb227119b5f2647d)</span></li>
<li>kioslave/http/tests/httpobjecttest.cpp <span style="color: grey">(37ea25d33e1866804a500ff640231d1e9e8c8b99)</span></li>
<li>staging/kde4attic/autotests/kdatetimeformattertest.cpp <span style="color: grey">(159ed7a735527c0078b8bee84dafe8f8ff3e490b)</span></li>
<li>staging/kde4attic/autotests/klocaletest.cpp <span style="color: grey">(a307e4896191b76549f052cc32acd4b83f0f39fc)</span></li>
<li>staging/kde4support/autotests/kasciitest.cpp <span style="color: grey">(fb1177ef675d093b8e5fca83d3a1719cf832e91d)</span></li>
<li>staging/kde4support/autotests/klibloadertest.cpp <span style="color: grey">(c1feb4fc7f59f33ef1ad0bf68c13ea3749403402)</span></li>
<li>staging/kde4support/autotests/kmimetypetest.cpp <span style="color: grey">(7466e565290663f8ac3b8c9c0b64132188c5d51d)</span></li>
<li>staging/kde4support/src/kdecore/k3bufferedsocket.cpp <span style="color: grey">(d90a371e142400386ba3b2ee04c04f85e0ca45af)</span></li>
<li>staging/kde4support/src/kdecore/k3clientsocketbase.cpp <span style="color: grey">(96e99a2024f65aa3b834051d146a962504d83467)</span></li>
<li>staging/kde4support/src/kdecore/k3resolver.cpp <span style="color: grey">(539cf4085dcd949b89d154738d042c673d98a3e2)</span></li>
<li>staging/kde4support/src/kdecore/k3reverseresolver.cpp <span style="color: grey">(2e261135c210802e6a3a6f69252d48d6054323f0)</span></li>
<li>staging/kde4support/src/kdecore/k3serversocket.cpp <span style="color: grey">(b6b29837ca35aeff24fae3560bfed3a746ce3d92)</span></li>
<li>staging/kde4support/src/kdecore/k3socketbase.cpp <span style="color: grey">(43651cb9e64a3135e2a40f5c75be73a0da0a84b7)</span></li>
<li>staging/kde4support/src/kdecore/k3streamsocket.cpp <span style="color: grey">(27ae4a93e3b0191439474d36bc16e61a03516b35)</span></li>
<li>staging/kde4support/src/kdecore/klibloader.cpp <span style="color: grey">(10fea2cdde619e2f8ba768c3820a1b0364a3238c)</span></li>
<li>staging/kio/autotests/clipboardupdatertest.cpp <span style="color: grey">(d7fcfd40bf09378d26f7e901848d488009a93d5e)</span></li>
<li>staging/kio/autotests/dataprotocoltest.cpp <span style="color: grey">(d73cc951dcb28edb4b469706a3b2a4ef0ee05067)</span></li>
<li>staging/kio/autotests/fileundomanagertest.cpp <span style="color: grey">(dfdeaeb7bc3da7af4e4d4da06b5da5704c906c05)</span></li>
<li>staging/kio/tests/previewtest.cpp <span style="color: grey">(bfc66bf33068731a5ad7f487bde950a08fa2b1e3)</span></li>
<li>staging/kservice/src/kdeinit/ktoolinvocation.cpp <span style="color: grey">(ef047b3847de6cdb61f73d4fd6723541e9359644)</span></li>
<li>staging/kservice/src/plugin/klibrary.cpp <span style="color: grey">(845ff9d24d5f0884dfd57cefe16a190d5b783230)</span></li>
<li>staging/kservice/src/plugin/kpluginfactory.cpp <span style="color: grey">(405d41ed63f8bf4d54334d437f443160c569a82b)</span></li>
<li>staging/kservice/src/plugin/kpluginloader.cpp <span style="color: grey">(798a9766c92e172977f02720d7c338b8d36a5bc8)</span></li>
<li>staging/kservice/src/services/kautostart.cpp <span style="color: grey">(f540e901a62819f4bd9fe9e3dc61560e30ef5ea1)</span></li>
<li>staging/kservice/src/sycoca/ksycoca.cpp <span style="color: grey">(2923172f985bbf744c9adfec3f23c514b7f20e46)</span></li>
<li>tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp <span style="color: grey">(7a7e4e65e312f0c5b7176d851c303c9df101ab08)</span></li>
<li>tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp <span style="color: grey">(75c91fc257c14a773fc22b405f84c8056b0880de)</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp <span style="color: grey">(6583a624a26cbaab4c58b262b4056d953cbb316e)</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp <span style="color: grey">(9bcd9ec79b140752255d06db8d15dc021ab3ce8b)</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp <span style="color: grey">(b1a1407c97df7a82832b4af0e1f7bb6d4127d9c9)</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.cpp <span style="color: grey">(9ff7d4bfe7f16ef583420a45d9f26b5c310b7e2e)</span></li>
<li>tier1/itemmodels/src/kmodelindexproxymapper.cpp <span style="color: grey">(c806e8a8476bdd40e1379a799a6f5c3d7d607fe2)</span></li>
<li>tier1/kconfig/src/core/kconfigbackend.cpp <span style="color: grey">(9bccf420f16737a170273c495b0858b8cca31d67)</span></li>
<li>tier1/kconfig/src/core/kcoreconfigskeleton.cpp <span style="color: grey">(ec2c9eedfbb515c97812b5bc78cf66653e9d6e2b)</span></li>
<li>tier1/kcoreaddons/autotests/kcompositejobtest.cpp <span style="color: grey">(d3d46276a2f8a4e799bda2211c7f0473903b5608)</span></li>
<li>tier1/kcoreaddons/tests/kdirwatchtest.cpp <span style="color: grey">(1ad3928e47b083c2ec21c2748a0e50e972be0d63)</span></li>
<li>tier1/kcoreaddons/tests/kdirwatchtest_gui.cpp <span style="color: grey">(edc4ce7e03d28e5b6963f2e4f7274ddf4a0ed41a)</span></li>
<li>tier1/kdbusaddons/src/kdedmodule.cpp <span style="color: grey">(bdd1ca1874d8255dda7ae828b6d9c1e14816e5b8)</span></li>
<li>tier1/kguiaddons/autotests/kiconutilstest.cpp <span style="color: grey">(3690c131c54bd328e3d135bbdd048e18597924a1)</span></li>
<li>tier1/kjs/autotests/ecmatest.cpp <span style="color: grey">(585516377dfc0cf63f4bb463bb1d27fd9031c3cb)</span></li>
<li>tier1/kplotting/examples/testplot_widget.cpp <span style="color: grey">(95e1a42894bef6b131a97aaf0ce43b0b86eb0d99)</span></li>
<li>tier1/solid/src/imports/devices.cpp <span style="color: grey">(05e6618000b1b273ebfd1eae3eb6fd64e9e84b4f)</span></li>
<li>tier1/solid/src/imports/solidextensionplugin.cpp <span style="color: grey">(a019f7fbfdaeb7ba6b651fb69dd34458a91494b8)</span></li>
<li>tier1/solid/src/solid/backends/wmi/wmicdrom.cpp <span style="color: grey">(f74a893ce4f7a153818b5be5154e1b8c056a51f4)</span></li>
<li>tier1/solid/src/solid/backends/wmi/wmidevice.cpp <span style="color: grey">(32dd9d5c8c86f838fa49a9c6d6932a87edbe58bb)</span></li>
<li>tier1/solid/src/solid/backends/wmi/wmimanager.cpp <span style="color: grey">(8c3dcd9f7977c64885d1f4f6b4d37acf9a45990c)</span></li>
<li>tier1/solid/src/solid/backends/wmi/wmistorage.cpp <span style="color: grey">(3456b9040d83363fd8c3abef6eb029dd9e5695e5)</span></li>
<li>tier1/solid/src/solid/backends/wmi/wmistorageaccess.cpp <span style="color: grey">(05cc3d875f49a43c33315acd1c8f93ab6a39bba0)</span></li>
<li>tier1/solid/src/solid/backends/wmi/wmivolume.cpp <span style="color: grey">(d962e709d97f0f6113dd6b159386668d6555b1be)</span></li>
<li>tier1/solid/src/solid/networking_win.cpp <span style="color: grey">(39e3bddc77b73d8d44a11c717eaca86de0d7a2b0)</span></li>
<li>tier1/solid/tests/solidnettestdbusservice.cpp <span style="color: grey">(3150af718e626ed33f1031874606a9bac49fce00)</span></li>
<li>tier1/sonnet/autotests/test_core.cpp <span style="color: grey">(a6820bb6b881f67b9a3bc2cb83729ae0fd234c67)</span></li>
<li>tier1/sonnet/autotests/test_filter.cpp <span style="color: grey">(d3bfa9dfa4bdb84f6698f96177e721ec7891aba5)</span></li>
<li>tier1/sonnet/src/plugins/aspell/kspell_aspellclient.cpp <span style="color: grey">(9b2d4be5a276b5a37218cd7cacc4a9956ca41d94)</span></li>
<li>tier1/sonnet/src/plugins/hunspell/kspell_hunspellclient.cpp <span style="color: grey">(8f9641c1ff5d977cd98eab344b5b85fa66f802dd)</span></li>
<li>tier1/sonnet/src/ui/spellcheckdecorator.cpp <span style="color: grey">(74f2adc66e8faa45aa4d62f4adb1968fc7dac9eb)</span></li>
<li>tier1/sonnet/tests/test_dialog.cpp <span style="color: grey">(162f5cbdf1dc8ddb172ffe227a2b128fd51fca9a)</span></li>
<li>tier1/threadweaver/autotests/AppendCharacterJob.cpp <span style="color: grey">(a8f7d1d8b00a4a1816c51f19461a4e25905825ac)</span></li>
<li>tier1/threadweaver/autotests/CMakeLists.txt <span style="color: grey">(b36b2354b3132521f6ed4bb70e3bdeb47a6556bc)</span></li>
<li>tier1/threadweaver/autotests/DeleteTest.cpp <span style="color: grey">(1fe4d059b760a1620bbb24b665583ff9f47af56b)</span></li>
<li>tier1/threadweaver/autotests/JobTests.cpp <span style="color: grey">(4351f330d2195fdaa74927e327c9b3a110e23cca)</span></li>
<li>tier1/threadweaver/autotests/QueueTests.cpp <span style="color: grey">(d08fba1f555762d2908eb7bdea720f581d71bee6)</span></li>
<li>tier1/threadweaver/src/Weaver/IncludeMocs.cpp <span style="color: grey">(6be019207a4e3d2a165e94dc1a16ed77ad1b96b3)</span></li>
<li>tier1/threadweaver/src/Weaver/Job.cpp <span style="color: grey">(26bfa633c0d19a3ca832a94955d0925662ee53d7)</span></li>
<li>tier1/threadweaver/src/Weaver/JobCollection.cpp <span style="color: grey">(bac3d22e25bc2a89cc72278f666fe6e1d0635079)</span></li>
<li>tier1/threadweaver/src/Weaver/JobSequence.cpp <span style="color: grey">(71ee339859856afd5d9b1875ccb9f043a9f6a4b6)</span></li>
<li>tier1/threadweaver/src/Weaver/QObjectDecorator.cpp <span style="color: grey">(3f754cfa8e145fdd04a863e75263b84eaf299a5c)</span></li>
<li>tier1/threadweaver/src/Weaver/Thread.cpp <span style="color: grey">(321f492e85acc7437577daf041999908a5ba2830)</span></li>
<li>tier1/threadweaver/src/Weaver/WeaverImpl.cpp <span style="color: grey">(d4955b3f9a70d200b62449e9209d5bf2b315143e)</span></li>
<li>tier1/threadweaver/src/Weaver/WeaverObserver.cpp <span style="color: grey">(361ea61b46771f777e4e0254b071f747c9183ad3)</span></li>
<li>tier1/threadweaver/src/WeaverGui/WeaverThreadGrid.cpp <span style="color: grey">(47d97876bbd2587bd5dd856154e7ddbe2108b79c)</span></li>
<li>tier2/dnssd/src/mdnsd-domainbrowser.cpp <span style="color: grey">(384014aada9c04599ccf5c7631b2502cfdd4de42)</span></li>
<li>tier2/dnssd/src/mdnsd-responder.cpp <span style="color: grey">(2118853f7e8a44d6cfaa26beb7625d4dc30f53b1)</span></li>
<li>tier2/dnssd/src/mdnsd-servicebrowser.cpp <span style="color: grey">(00918c305fbaa78c94d6e790e5c8d3a44f227a4b)</span></li>
<li>tier2/dnssd/src/mdnsd-servicetypebrowser.cpp <span style="color: grey">(a5bf621990da9b562d3c8dd28e6596a8868248c6)</span></li>
<li>tier2/kauth/src/AuthBackend.cpp <span style="color: grey">(c953b81ace36376a91530e3b3c8d1c92f7a3305b)</span></li>
<li>tier2/kauth/src/backends/fakehelper/FakeHelperProxy.cpp <span style="color: grey">(36435bf0d82b62290105d624a630b6866f30ca8a)</span></li>
<li>tier2/knotifications/tests/kstatusnotifieritemtest.cpp <span style="color: grey">(40b130d7a0a6cd85466ac54a53a012224061bc1f)</span></li>
<li>tier2/kwallet/src/kwallet_mac.cpp <span style="color: grey">(6b6737d825b1b97043952eea6d8856fc3bc7b327)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113391/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>