<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112985/">http://git.reviewboard.kde.org/r/112985/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Gil Oliva.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2013, 10:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adjust API in KEmoticons framework: map and index methods
-Make map and index KEmoticons API slightly clearer and deprecate
the methods that are confusing.
-Use the new methods in the plugins.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds. It installs. Tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kemoticons/src/core/kemoticonsprovider.h <span style="color: grey">(85fc7efb8923d76476f0a16f70f8ebb15e451081)</span></li>
<li>staging/kemoticons/src/core/kemoticonsprovider.cpp <span style="color: grey">(d04c76e87b118f5d45717b3b2ccd9dea47dc2526)</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.cpp <span style="color: grey">(a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17)</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.cpp <span style="color: grey">(5b5114a14dd94a6ebcba8a6f7dd163f73048189a)</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp <span style="color: grey">(e9f89eecce3d6e6407113a84cb5200ff66564c19)</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp <span style="color: grey">(0dc92ed092d87a559fe7fa1a40e804843ab73d59)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112985/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>