<div dir="ltr">On Mon, Oct 21, 2013 at 2:54 PM, Stephen Kelly <span dir="ltr"><<a href="mailto:steveire@gmail.com" target="_blank">steveire@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Git commit 5e9404239fb974973e8a253444131884954ede77 by Stephen Kelly.<br>
Committed on 21/10/2013 at 12:49.<br>
Pushed by skelly into branch 'frameworks'.<br>
<br>
Add include/KDE to users of KIOCore.<br>
<br>
Note that this really only hides the problem. There are several problems<br>
with the KF5 includes, and several patches in review which also don't<br>
fully solve the problem.<br>
<br>
What is needed is to figure out<br>
<br>
* Where are headers installed to?<br>
* How are users supposed to use them?<br>
* What include paths do users need to use?<br>
<br>
For example, if kfoo installs<br>
<br>
 include/kfoo/job.h<br>
 include/kfoo/kfoo_export.h<br>
<br>
and users are supposed to use:<br>
<br>
 .#include <kfoo/job.h><br>
<br>
but job.h #includes <kfoo_export.h><br>
<br>
then users need both<br>
<br>
 include/<br>
 include/kfoo/<br>
<br>
when compiling. That seems to be the case at some points in KDE<br>
frameworks, and it is more-likely accidental than intentional.<br>
<br>
That should be reviewed.<br>
<br>
CCMAIL: <a href="mailto:kde-frameworks-devel@kde.org">kde-frameworks-devel@kde.org</a><br>
<br>
M  +1    -0    staging/kio/src/core/CMakeLists.txt<br>
<br>
<a href="http://commits.kde.org/kdelibs/5e9404239fb974973e8a253444131884954ede77" target="_blank">http://commits.kde.org/kdelibs/5e9404239fb974973e8a253444131884954ede77</a><br>
<br>
diff --git a/staging/kio/src/core/CMakeLists.txt b/staging/kio/src/core/CMakeLists.txt<br>
index 273086f..03a892b 100644<br>
--- a/staging/kio/src/core/CMakeLists.txt<br>
+++ b/staging/kio/src/core/CMakeLists.txt<br>
@@ -108,6 +108,7 @@ target_include_directories(KIOCore PUBLIC<br>
   "$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/..>" # kio_version.h<br>
   "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/kssl>"<br>
   "$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/../include>" # kio/global.h<br>
+  "$<INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}/KDE>" # KIO/Job<br>
 )<br>
<br>
 target_link_libraries(KIOCore<br>
_______________________________________________<br>
Kde-frameworks-devel mailing list<br>
<a href="mailto:Kde-frameworks-devel@kde.org">Kde-frameworks-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-frameworks-devel" target="_blank">https://mail.kde.org/mailman/listinfo/kde-frameworks-devel</a><br>
</blockquote></div><br></div><div class="gmail_extra">FWIW, KDE/ should be added to most modules then...</div><div class="gmail_extra"><br></div><div class="gmail_extra">Aleix</div></div>