<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113248/">http://git.reviewboard.kde.org/r/113248/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 15th, 2013, 1:51 p.m. UTC, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Standalone build fails here with this message:
-- Found KF5: /home/aurelien/opt/kf5/share/ECM/find-modules/FindKF5.cmake (found suitable version "5.0.0", minimum required is "5.0.0") found components: CMake Compiler InstallDirs
CMake Error at CMakeLists.txt:19 (find_package):
Found package configuration file:
/home/aurelien/opt/kf5/lib/x86_64-linux-gnu/cmake/KIO/KIOConfig.cmake
but it set KIO_FOUND to FALSE so package "KIO" is considered to be NOT
FOUND. Reason given by package:
The following imported targets are referenced, but are missing:
KF5::KBookmarks KF5::XmlGui KF5::Solid
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is it really a problem in KNotifyConfig? I'd say it is in KIO...</pre>
<br />
<p>- Aleix</p>
<br />
<p>On October 14th, 2013, 5:33 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Oct. 14, 2013, 5:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sort dependencies out, adopt the different cmake constructions to make sure everything will be installed properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">builds, teh test seems to work still.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/knotifyconfig/CMakeLists.txt <span style="color: grey">(65867ba)</span></li>
<li>staging/knotifyconfig/KNotifyConfigConfig.cmake.in <span style="color: grey">(fbdea78)</span></li>
<li>staging/knotifyconfig/src/CMakeLists.txt <span style="color: grey">(9be9ba4)</span></li>
<li>staging/knotifyconfig/tests/CMakeLists.txt <span style="color: grey">(1ed0360)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113248/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>