<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113154/">http://git.reviewboard.kde.org/r/113154/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 14th, 2013, 7:31 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-1
I disagree with the removal, OK they get deprecated in KDE4... but it's been done only recently (the patch isn't even in yet). We still have a couple of users for those classes and it would be one more breakage on our SC promise (and one we can avoid at that).</pre>
</blockquote>
<p>On October 14th, 2013, 7:32 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Of course I meant for the removals in kde4support. The comments cleanup in kio I'm fine with it.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, avoiding that would be mean that I need to either (1) port it to Nepomuk2 and thus get a dependency to nepomuk-core or (2) remove all the Nepomuk code. If it is really required I can go with (2), though it'll be a lot more work.
The nepomuk-core replacement classes are almost source compatible with the kio ones. So the port is mostly just changing the class name, and linking to the new library. Also, Konversation and Conquire (Nepomuk app) seems to be the only users of this class. KGet has been ported.
Do you still want me to go with (2)?</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On October 10th, 2013, 12:56 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Oct. 10, 2013, 12:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Remove KFileMetaDataWidget and friends
These have been deprecated in KDE4.[1] This also removes the
KFileMetaPropsPlugin in the KPropertiesDialog - The code was commented
out so it doesn't really make a difference.
Eventually we will need a proper plugin based system so that the
Nepomuk2::FileMetadataWidget can be used in the KPropertiesDialog
[1] https://git.reviewboard.kde.org/r/113153/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDE5PORTING.html <span style="color: grey">(3171afc)</span></li>
<li>kdewidgets/kde.widgets <span style="color: grey">(b138d4e)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(5eb649c)</span></li>
<li>staging/kde4support/src/kio/kcommentwidget.cpp <span style="color: grey">(6223a0c)</span></li>
<li>staging/kde4support/src/kio/kcommentwidget_p.h <span style="color: grey">(7a9c710)</span></li>
<li>staging/kde4support/src/kio/kfilemetadataconfigurationwidget.h <span style="color: grey">(52735ad)</span></li>
<li>staging/kde4support/src/kio/kfilemetadataconfigurationwidget.cpp <span style="color: grey">(018d183)</span></li>
<li>staging/kde4support/src/kio/kfilemetadataprovider.cpp <span style="color: grey">(59cb238)</span></li>
<li>staging/kde4support/src/kio/kfilemetadataprovider_p.h <span style="color: grey">(0969f53)</span></li>
<li>staging/kde4support/src/kio/kfilemetadatareader.cpp <span style="color: grey">(6a7909c)</span></li>
<li>staging/kde4support/src/kio/kfilemetadatareader_p.h <span style="color: grey">(af054c2)</span></li>
<li>staging/kde4support/src/kio/kfilemetadatareaderprocess.cpp <span style="color: grey">(0d2b993)</span></li>
<li>staging/kde4support/src/kio/kfilemetadatawidget.h <span style="color: grey">(31dd3c7)</span></li>
<li>staging/kde4support/src/kio/kfilemetadatawidget.cpp <span style="color: grey">(2df2312)</span></li>
<li>staging/kde4support/src/kio/kmetaprops.h <span style="color: grey">(b03dd4c)</span></li>
<li>staging/kde4support/src/kio/kmetaprops.cpp <span style="color: grey">(46624c5)</span></li>
<li>staging/kde4support/src/kio/knfotranslator.cpp <span style="color: grey">(0494679)</span></li>
<li>staging/kde4support/src/kio/knfotranslator_p.h <span style="color: grey">(ddbe4a1)</span></li>
<li>staging/kio/src/widgets/kpropertiesdialog.cpp <span style="color: grey">(63e4435)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113154/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>