<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113160/">http://git.reviewboard.kde.org/r/113160/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code looks fine.
reviewboard-am doesn't apply cleanly (possibly as it moves a file). Check it all builds from a clean slate - remember to update ECM too.</pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On October 7th, 2013, 6:18 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Oct. 7, 2013, 6:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moves KDeclarative to tier3
Also trim down the test so that it uses the module but it doesn't use something from upstream (such as plasma components)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the test starts and seems to work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier3/CMakeLists.txt <span style="color: grey">(11be8e4)</span></li>
<li>staging/kdeclarative/tests/testobject_p.h <span style="color: grey">()</span></li>
<li>staging/kdeclarative/tests/test.qml <span style="color: grey">(060c265)</span></li>
<li>staging/kdeclarative/tests/kdeclarativetest.cpp <span style="color: grey">(d5b9f96)</span></li>
<li>staging/kdeclarative/tests/CMakeLists.txt <span style="color: grey">(ad4a7db)</span></li>
<li>staging/kdeclarative/src/qmlobject_p.h <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/qmlobject.cpp <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/qmlobject.h <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/private/rootcontext_p.h <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/private/rootcontext.cpp <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/private/kiconprovider_p.h <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/private/kiconprovider.cpp <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/private/kdeclarative_p.h <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/kdeclarative.cpp <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/kdeclarative.h <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/configpropertymap.cpp <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/configpropertymap.h <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/bindings/url.cpp <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/bindings/qscriptnonguibookkeeping.cpp <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/bindings/icon.cpp <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/bindings/i18n_p.h <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/bindings/i18n.cpp <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/bindings/backportglobal.h <span style="color: grey">()</span></li>
<li>staging/kdeclarative/src/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kdeclarative/KDeclarativeConfig.cmake.in <span style="color: grey">()</span></li>
<li>staging/kdeclarative/CMakeLists.txt <span style="color: grey">(eefa756)</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(4f64e8a)</span></li>
<li>tier3/kdeclarative/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kdeclarative/tests/test.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113160/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>