<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113154/">http://git.reviewboard.kde.org/r/113154/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd like to see a mention in KDE5Porting.html...</pre>
 <br />









<p>- Aleix Pol Gonzalez</p>


<br />
<p>On October 7th, 2013, 5:01 p.m. UTC, Vishesh Handa wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Vishesh Handa.</div>


<p style="color: grey;"><i>Updated Oct. 7, 2013, 5:01 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">    Remove KFileMetaDataWidget and friends
    
    These have been deprecated in KDE4.[1] This also removes the
    KFileMetaPropsPlugin in the KPropertiesDialog - The code was commented
    out so it doesn't really make a difference.
    
    Eventually we will need a proper plugin based system so that the
    Nepomuk2::FileMetadataWidget can be used in the KPropertiesDialog

[1] https://git.reviewboard.kde.org/r/113153/</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(5eb649c)</span></li>

 <li>staging/kde4support/src/kio/kcommentwidget.cpp <span style="color: grey">(6223a0c)</span></li>

 <li>staging/kde4support/src/kio/kcommentwidget_p.h <span style="color: grey">(7a9c710)</span></li>

 <li>staging/kde4support/src/kio/kfilemetadataconfigurationwidget.h <span style="color: grey">(52735ad)</span></li>

 <li>staging/kde4support/src/kio/kfilemetadataconfigurationwidget.cpp <span style="color: grey">(018d183)</span></li>

 <li>staging/kde4support/src/kio/kfilemetadataprovider.cpp <span style="color: grey">(59cb238)</span></li>

 <li>staging/kde4support/src/kio/kfilemetadataprovider_p.h <span style="color: grey">(0969f53)</span></li>

 <li>staging/kde4support/src/kio/kfilemetadatareader.cpp <span style="color: grey">(6a7909c)</span></li>

 <li>staging/kde4support/src/kio/kfilemetadatareader_p.h <span style="color: grey">(af054c2)</span></li>

 <li>staging/kde4support/src/kio/kfilemetadatareaderprocess.cpp <span style="color: grey">(0d2b993)</span></li>

 <li>staging/kde4support/src/kio/kfilemetadatawidget.h <span style="color: grey">(31dd3c7)</span></li>

 <li>staging/kde4support/src/kio/kfilemetadatawidget.cpp <span style="color: grey">(2df2312)</span></li>

 <li>staging/kde4support/src/kio/kmetaprops.h <span style="color: grey">(b03dd4c)</span></li>

 <li>staging/kde4support/src/kio/kmetaprops.cpp <span style="color: grey">(46624c5)</span></li>

 <li>staging/kde4support/src/kio/knfotranslator.cpp <span style="color: grey">(0494679)</span></li>

 <li>staging/kde4support/src/kio/knfotranslator_p.h <span style="color: grey">(ddbe4a1)</span></li>

 <li>staging/kio/src/widgets/kpropertiesdialog.cpp <span style="color: grey">(63e4435)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113154/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>