<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113179/">http://git.reviewboard.kde.org/r/113179/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 8th, 2013, 9:15 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's also runner-related code in src/declarativeimports/{core,runnermodel}, these should be reenabled as well. Possibly, they also need changes to make built. I had disabled this after a discussion with Aaron (who has refactored these classes) and Vishesh, who plans to work on them. I'm not sure what's the most useful, I can imagine this leading to a lot of conflicts when merging this refactoring, while the benefits of this patch are then just going away. Aaron can weigh in here to say what's easiest moving forward. Mirko is the best person to review the ThreadWeaver API changes you implement. Could you add him to the reviewers for this request?
thanks...</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, the only reason I did this was because kickoff in kde-workspace requires runners as well. If those are not good anymore, maybe it's wiser to disable them there as well?</pre>
<br />
<p>- Aleix</p>
<br />
<p>On October 8th, 2013, 5:14 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2013, 5:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Recently there's been some big changes in the ThreadWeaver API. So big that they break the source compatibility we were supposed to maintain, big time.
This patch tries to port plasma-framework to that new API.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything builds, including kde-workspace.
Couldn't test it, there's no tests for it or even an application to test it :/.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/CMakeLists.txt <span style="color: grey">(411256a)</span></li>
<li>src/plasma/private/runnerjobs.cpp <span style="color: grey">(d11f7e9)</span></li>
<li>src/plasma/private/runnerjobs_p.h <span style="color: grey">(7fd7076)</span></li>
<li>src/plasma/private/storage.cpp <span style="color: grey">(35b222e)</span></li>
<li>src/plasma/runnermanager.cpp <span style="color: grey">(135279e)</span></li>
<li>src/plasma/scripting/runnerscript.cpp <span style="color: grey">(d5142a2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113179/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>