<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113148/">http://git.reviewboard.kde.org/r/113148/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 7th, 2013, 2:47 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113148/diff/1/?file=199659#file199659line48" style="color: black; font-weight: bold; text-decoration: underline;">staging/kservice/kbuildsycoca/kbuildsycoca.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if !KBUILDSYCOCA_NO_KCRASH</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if !KBUILDSYCOCA_NO_KCRASH</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What happens with this?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I vote for removing it, any objections ?</pre>
<br />
<p>- Àlex</p>
<br />
<p>On October 7th, 2013, 3:21 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Oct. 7, 2013, 3:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moved KBuildsyscoca to KService.
I have done the moving and the cleaning in different commits, just unified them for reviewboard.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kded/CMakeLists.txt <span style="color: grey">(4f9133f)</span></li>
<li>kded/applications.menu <span style="color: grey">()</span></li>
<li>kded/kbuildmimetypefactory.h <span style="color: grey">()</span></li>
<li>kded/kbuildmimetypefactory.cpp <span style="color: grey">(2e81ce7)</span></li>
<li>kded/kbuildservicefactory.h <span style="color: grey">()</span></li>
<li>kded/kbuildservicefactory.cpp <span style="color: grey">(971f327)</span></li>
<li>kded/kbuildservicegroupfactory.h <span style="color: grey">()</span></li>
<li>kded/kbuildservicegroupfactory.cpp <span style="color: grey">(5485b1c)</span></li>
<li>kded/kbuildservicetypefactory.h <span style="color: grey">()</span></li>
<li>kded/kbuildservicetypefactory.cpp <span style="color: grey">(f473cd6)</span></li>
<li>kded/kbuildsycoca.h <span style="color: grey">()</span></li>
<li>kded/kbuildsycoca.cpp <span style="color: grey">(8ea2d2e)</span></li>
<li>kded/kbuildsycocainterface.h <span style="color: grey">()</span></li>
<li>kded/kctimefactory.h <span style="color: grey">()</span></li>
<li>kded/kctimefactory.cpp <span style="color: grey">()</span></li>
<li>kded/kmimeassociations.h <span style="color: grey">()</span></li>
<li>kded/kmimeassociations.cpp <span style="color: grey">()</span></li>
<li>kded/ksycocaresourcelist.h <span style="color: grey">()</span></li>
<li>kded/tests/CMakeLists.txt <span style="color: grey">(ca392d2)</span></li>
<li>kded/tests/kmimeassociationstest.cpp <span style="color: grey">()</span></li>
<li>kded/vfolder_menu.h <span style="color: grey">()</span></li>
<li>kded/vfolder_menu.cpp <span style="color: grey">()</span></li>
<li>staging/kservice/CMakeLists.txt <span style="color: grey">(b244731)</span></li>
<li>staging/kservice/kbuildsycoca/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kservice/tests/CMakeLists.txt <span style="color: grey">(23d4854)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113148/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>