<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113077/">http://git.reviewboard.kde.org/r/113077/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 7th, 2013, 4:38 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You broke the build (and forgot to include the REVIEW tag ;-):
[ 41%] Building CXX object kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o
In file included from /home/martin/kf5/src/kdelibs-frameworks/kross/src/core/krossconfig.cpp:20:0:
/home/martin/kf5/src/kdelibs-frameworks/kross/src/core/krossconfig.h:23:41: fatal error: kross/core/krosscore_export.h: No such file or directory
#include <kross/core/krosscore_export.h>
^
compilation terminated.
make[2]: *** [kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o] Error 1
make[1]: *** [kross/src/core/CMakeFiles/KrossCore.dir/all] Error 2</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">seems like Kevin already fixed it</pre>
<br />
<p>- Martin</p>
<br />
<p>On October 3rd, 2013, 6:09 p.m. CEST, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2013, 6:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes kross ready for moving to tier3. The changes were done in a separate branch (which I can push if required). The git log looks like this -
783b0a3 Kross: Remove module name from the header includes
8b7ac05 Kross: Do not set EXECUTABLE_OUTPUT_PATH
6c62ace Kross: Add feature_summary
d9b63be Kross: Install the plugins in the QT_PLULGIN_INSTALL_DIR
2c627df Kross: Add CMake stuff along with KrossConfig.cmake
a28624b Kross: Follow frameworks directory scheme
741b86c KRoss: Camel case the library names
Kross does not have any unit tests, and some of its normal tests seem to be segfaulting as well. I'm not sure what to do about that. Also when Kross is being split, its other plugins will needs to be added as well. Kdelibs only contains the kjs and QtScript plugins.
And finally, the QtScript plugin has a test - Should that be moved to the tests folder?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some tests segfault. Some of them run. I should probably convert them into autotests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kross/CMakeLists.txt <span style="color: grey">(3424cb8)</span></li>
<li>kross/KrossConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>kross/console/CMakeLists.txt <span style="color: grey">(da73a6f)</span></li>
<li>kross/console/main.cpp <span style="color: grey">()</span></li>
<li>kross/core/CMakeLists.txt <span style="color: grey">(5a8b845)</span></li>
<li>kross/core/action.h <span style="color: grey">(3f4d985)</span></li>
<li>kross/core/action.cpp <span style="color: grey">(5c6ee2c)</span></li>
<li>kross/core/actioncollection.h <span style="color: grey">(9e90df6)</span></li>
<li>kross/core/actioncollection.cpp <span style="color: grey">(89d8282)</span></li>
<li>kross/core/childreninterface.h <span style="color: grey">(0b11b2e)</span></li>
<li>kross/core/errorinterface.h <span style="color: grey">(bb23235)</span></li>
<li>kross/core/interpreter.h <span style="color: grey">(95293e4)</span></li>
<li>kross/core/interpreter.cpp <span style="color: grey">()</span></li>
<li>kross/core/krossconfig.h <span style="color: grey">(481c4b6)</span></li>
<li>kross/core/krossconfig.cpp <span style="color: grey">()</span></li>
<li>kross/core/manager.h <span style="color: grey">(aefdf87)</span></li>
<li>kross/core/manager.cpp <span style="color: grey">(e0dddf1)</span></li>
<li>kross/core/metafunction.h <span style="color: grey">(1413289)</span></li>
<li>kross/core/metatype.h <span style="color: grey">(08f7c6c)</span></li>
<li>kross/core/object.h <span style="color: grey">(6f2b6a4)</span></li>
<li>kross/core/object.cpp <span style="color: grey">()</span></li>
<li>kross/core/script.h <span style="color: grey">(1701883)</span></li>
<li>kross/core/script.cpp <span style="color: grey">()</span></li>
<li>kross/core/wrapperinterface.h <span style="color: grey">()</span></li>
<li>kross/kjs/CMakeLists.txt <span style="color: grey">(94af9ae)</span></li>
<li>kross/kjs/kjsinterpreter.h <span style="color: grey">()</span></li>
<li>kross/kjs/kjsinterpreter.cpp <span style="color: grey">()</span></li>
<li>kross/kjs/kjsscript.h <span style="color: grey">()</span></li>
<li>kross/kjs/kjsscript.cpp <span style="color: grey">()</span></li>
<li>kross/modules/CMakeLists.txt <span style="color: grey">(7391bb0)</span></li>
<li>kross/modules/form.h <span style="color: grey">(2da62c7)</span></li>
<li>kross/modules/form.cpp <span style="color: grey">(862b71b)</span></li>
<li>kross/modules/translation.h <span style="color: grey">()</span></li>
<li>kross/modules/translation.cpp <span style="color: grey">()</span></li>
<li>kross/qts/CMakeLists.txt <span style="color: grey">(b85c1c7)</span></li>
<li>kross/qts/interpreter.h <span style="color: grey">()</span></li>
<li>kross/qts/interpreter.cpp <span style="color: grey">()</span></li>
<li>kross/qts/main.cpp <span style="color: grey">()</span></li>
<li>kross/qts/plugin.h <span style="color: grey">()</span></li>
<li>kross/qts/plugin.cpp <span style="color: grey">()</span></li>
<li>kross/qts/script.h <span style="color: grey">()</span></li>
<li>kross/qts/script.cpp <span style="color: grey">()</span></li>
<li>kross/qts/test.es <span style="color: grey">()</span></li>
<li>kross/qts/values_p.h <span style="color: grey">()</span></li>
<li>kross/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kross/src/modules/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kross/test/CMakeLists.txt <span style="color: grey">(c931ec4)</span></li>
<li>kross/test/main.cpp <span style="color: grey">(da926fb)</span></li>
<li>kross/test/profile.py <span style="color: grey">()</span></li>
<li>kross/test/testguiform.py <span style="color: grey">()</span></li>
<li>kross/test/testguiform.rb <span style="color: grey">()</span></li>
<li>kross/test/testguiform.ui <span style="color: grey">()</span></li>
<li>kross/test/testguiqt.py <span style="color: grey">()</span></li>
<li>kross/test/testguiqt.rb <span style="color: grey">()</span></li>
<li>kross/test/testguitk.py <span style="color: grey">()</span></li>
<li>kross/test/testkross.js <span style="color: grey">()</span></li>
<li>kross/test/testkross.py <span style="color: grey">()</span></li>
<li>kross/test/testobject.h <span style="color: grey">(5383073)</span></li>
<li>kross/test/testobject.cpp <span style="color: grey">(560d88c)</span></li>
<li>kross/test/unittest.es <span style="color: grey">()</span></li>
<li>kross/test/unittest.js <span style="color: grey">()</span></li>
<li>kross/test/unittest.py <span style="color: grey">()</span></li>
<li>kross/test/unittest.rb <span style="color: grey">()</span></li>
<li>kross/ui/CMakeLists.txt <span style="color: grey">(14ba2d8)</span></li>
<li>kross/ui/model.h <span style="color: grey">(314ff24)</span></li>
<li>kross/ui/model.cpp <span style="color: grey">(4849149)</span></li>
<li>kross/ui/plugin.h <span style="color: grey">()</span></li>
<li>kross/ui/plugin.cpp <span style="color: grey">()</span></li>
<li>kross/ui/view.h <span style="color: grey">(4241aad)</span></li>
<li>kross/ui/view.cpp <span style="color: grey">()</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113077/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>