<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113100/">http://git.reviewboard.kde.org/r/113100/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- David Faure</p>
<br />
<p>On October 4th, 2013, 5:20 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Oct. 4, 2013, 5:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Depends on KService (one call, hard to replace) and KCoreAddons (could be probably replaced (KUser::loginName())).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As discussed in the frameworks meeting, KDESu is excused from tests, so no tests added. Builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/CMakeLists.txt <span style="color: grey">(18df1e4)</span></li>
<li>staging/kdesu/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kdesu/KDESuConfig.cmake.in <span style="color: grey">()</span></li>
<li>staging/kdesu/src/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kdesu/src/Mainpage.dox <span style="color: grey">()</span></li>
<li>staging/kdesu/src/README <span style="color: grey">()</span></li>
<li>staging/kdesu/src/client.h <span style="color: grey">()</span></li>
<li>staging/kdesu/src/client.cpp <span style="color: grey">()</span></li>
<li>staging/kdesu/src/config-kdesu.h.cmake <span style="color: grey">()</span></li>
<li>staging/kdesu/src/defaults.h <span style="color: grey">()</span></li>
<li>staging/kdesu/src/kcookie.cpp <span style="color: grey">()</span></li>
<li>staging/kdesu/src/kcookie_p.h <span style="color: grey">()</span></li>
<li>staging/kdesu/src/kdesu_stub.c <span style="color: grey">()</span></li>
<li>staging/kdesu/src/process.h <span style="color: grey">()</span></li>
<li>staging/kdesu/src/process.cpp <span style="color: grey">()</span></li>
<li>staging/kdesu/src/ssh.h <span style="color: grey">()</span></li>
<li>staging/kdesu/src/ssh.cpp <span style="color: grey">()</span></li>
<li>staging/kdesu/src/stub.h <span style="color: grey">()</span></li>
<li>staging/kdesu/src/stub.cpp <span style="color: grey">()</span></li>
<li>staging/kdesu/src/su.h <span style="color: grey">()</span></li>
<li>staging/kdesu/src/su.cpp <span style="color: grey">()</span></li>
<li>tier3/CMakeLists.txt <span style="color: grey">(5d4743f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113100/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>