<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113045/">http://git.reviewboard.kde.org/r/113045/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 2nd, 2013, 11:02 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113045/diff/1/?file=193397#file193397line23" style="color: black; font-weight: bold; text-decoration: underline;">staging/kcmutils/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">23</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">remove_definitions</span><span class="p">(</span><span class="s">-DQT_NO_CAST_TO_ASCII</span><span class="p">)</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why removing these?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As I understand it everything should compile with -DQT_NO_CAST_TO_ASCII, it was previously added here to make it compile before all the "blah" -> QLiteralString("blah") changes.</pre>
<br />
<p>- David</p>
<br />
<p>On October 2nd, 2013, 8:06 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Oct. 2, 2013, 8:06 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only find publicly used libraries in cmake.in
KCategoryDrawer -> KCategoryDrawerV3
No QString cast from ascii
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kcmutils/CMakeLists.txt <span style="color: grey">(dc577d3)</span></li>
<li>staging/kcmutils/KCMUtilsConfig.cmake.in <span style="color: grey">(c67ad52)</span></li>
<li>staging/kcmutils/src/CMakeLists.txt <span style="color: grey">(dc19649)</span></li>
<li>staging/kcmutils/src/kcmodulecontainer.cpp <span style="color: grey">(c08eda2)</span></li>
<li>staging/kcmutils/src/kcmoduleinfo.cpp <span style="color: grey">(f46308c)</span></li>
<li>staging/kcmutils/src/kcmoduleproxy.cpp <span style="color: grey">(d2db3ab)</span></li>
<li>staging/kcmutils/src/kcmultidialog.cpp <span style="color: grey">(4812407)</span></li>
<li>staging/kcmutils/src/kpluginselector.cpp <span style="color: grey">(77cbfda)</span></li>
<li>staging/kcmutils/src/kpluginselector_p.h <span style="color: grey">(2dffae0)</span></li>
<li>staging/kcmutils/src/ksettings/componentsdialog.cpp <span style="color: grey">(111549a)</span></li>
<li>staging/kcmutils/src/ksettings/dialog.cpp <span style="color: grey">(131f75f)</span></li>
<li>staging/kcmutils/src/ksettings/dispatcher.cpp <span style="color: grey">(48bb0fc)</span></li>
<li>staging/kcmutils/src/ksettings/pluginpage.cpp <span style="color: grey">(0577908)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113045/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>