<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112966/">http://git.reviewboard.kde.org/r/112966/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Kevin Ottens and Martin Gräßlin.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Oct. 1, 2013, 3:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review dispatches content of the KInterProcessWindowing framework to other frameworks:
- KMessageBox methods are moved to KWidgetsAddons, with a small duplication of code from KWindowSystem
- KUserTimestamp namespace is moved to KWindowSystem</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still builds, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0939738)</span></li>
<li>KDE5PORTING.html <span style="color: grey">(57ecf2e)</span></li>
<li>KDELibs4Config.cmake <span style="color: grey">(562fa3a)</span></li>
<li>khtml/java/CMakeLists.txt <span style="color: grey">(daa51ee)</span></li>
<li>khtml/java/tests/CMakeLists.txt <span style="color: grey">(eaa715a)</span></li>
<li>kioslave/http/kcookiejar/CMakeLists.txt <span style="color: grey">(b3985fb)</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(900bdae)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(46fce06)</span></li>
<li>staging/kde4support/src/kdeui/kmessagebox_queued.cpp <span style="color: grey">(54db324)</span></li>
<li>staging/kinterprocesswindowing/CMakeLists.txt <span style="color: grey">(3cb2127)</span></li>
<li>staging/kinterprocesswindowing/KInterProcessWindowingConfig.cmake.in <span style="color: grey">(717587c)</span></li>
<li>staging/kinterprocesswindowing/src/CMakeLists.txt <span style="color: grey">(126f9bf)</span></li>
<li>staging/kinterprocesswindowing/src/config-kinterprocesswindowing.h.cmake <span style="color: grey">(5169547)</span></li>
<li>staging/kinterprocesswindowing/src/kmessagebox_kiw.h <span style="color: grey">(e53a18f)</span></li>
<li>staging/kinterprocesswindowing/src/kmessagebox_kiw.cpp <span style="color: grey">(3b63c9a)</span></li>
<li>staging/kinterprocesswindowing/src/kusertimestamp.h <span style="color: grey">(0316a15)</span></li>
<li>staging/kinterprocesswindowing/src/kusertimestamp.cpp <span style="color: grey">(38459e0)</span></li>
<li>staging/kinterprocesswindowing/tests/CMakeLists.txt <span style="color: grey">(b326815)</span></li>
<li>staging/kinterprocesswindowing/tests/kmessageboxwidtest.h <span style="color: grey">(097756a)</span></li>
<li>staging/kinterprocesswindowing/tests/kmessageboxwidtest.cpp <span style="color: grey">(972e57e)</span></li>
<li>tier1/kwidgetsaddons/src/kmessagebox.h <span style="color: grey">(f34c2c4)</span></li>
<li>tier1/kwidgetsaddons/src/kmessagebox.cpp <span style="color: grey">(1fff72f)</span></li>
<li>tier1/kwidgetsaddons/tests/CMakeLists.txt <span style="color: grey">(4297a3b)</span></li>
<li>tier1/kwidgetsaddons/tests/kmessageboxwidtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwindowsystem/src/CMakeLists.txt <span style="color: grey">(31fb53e)</span></li>
<li>tier1/kwindowsystem/src/kusertimestamp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwindowsystem/src/kusertimestamp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112966/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>