<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112935/">http://git.reviewboard.kde.org/r/112935/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 273a89d6f10a9c2508ffd9a4394bb78417ebc126 by Martin Klapetek to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On September 25th, 2013, 4:50 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and John Layt.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2013, 4:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moves KPrintDialog out of kde4attic into KPrintUtils. Patch contains some changes like KComboBox -> QComboBox etc and also removes couple of image icons, which are no longer needed (was part of a feature merged in qt).
Will do separate commits.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kde4attic/src/CMakeLists.txt <span style="color: grey">(74ecc39)</span></li>
<li>staging/kde4attic/src/kcupsoptionsjobwidget_p.h <span style="color: grey">()</span></li>
<li>staging/kde4attic/src/kcupsoptionspageswidget.ui <span style="color: grey">(0b6231b)</span></li>
<li>staging/kde4attic/src/kcupsoptionspageswidget_p.h <span style="color: grey">()</span></li>
<li>staging/kde4attic/src/kcupsoptionspageswidget_p.cpp <span style="color: grey">(5290405)</span></li>
<li>staging/kde4attic/src/kcupsoptionssettingswidget_p.h <span style="color: grey">()</span></li>
<li>staging/kde4attic/src/kcupsoptionswidget_p.h <span style="color: grey">()</span></li>
<li>staging/kde4attic/src/kcupsoptionswidget_p.cpp <span style="color: grey">(9393fbf)</span></li>
<li>staging/kde4attic/src/kdeprint_nup1.png <span style="color: grey">(9f13429)</span></li>
<li>staging/kde4attic/src/kdeprint_nup2.png <span style="color: grey">(7289a7e)</span></li>
<li>staging/kde4attic/src/kdeprint_nup4.png <span style="color: grey">(b03a539)</span></li>
<li>staging/kde4attic/src/kdeprint_nupother.png <span style="color: grey">(5a7c385)</span></li>
<li>staging/kde4attic/src/kdeprintdialog.h <span style="color: grey">(5d9cd25)</span></li>
<li>staging/kde4attic/src/kdeprintdialog.cpp <span style="color: grey">(13f89a7)</span></li>
<li>staging/kprintutils/src/CMakeLists.txt <span style="color: grey">(a2e56c9)</span></li>
<li>staging/kprintutils/src/config-kprintutils.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112935/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>