<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112984/">http://git.reviewboard.kde.org/r/112984/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112984/diff/1/?file=193005#file193005line95" style="color: black; font-weight: bold; text-decoration: underline;">staging/kemoticons/src/core/kemoticonsprovider.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">93</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="kt">void</span> <span class="n">save</span><span class="p">()</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">95</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="kt">void</span> <span class="n">save</span><span class="p">()</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use KEMOTICONS_DEPRECATED</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't really understand what's better from ::save instead of ::saveTheme. Is it just the naming? They seem to do the same.</pre>
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On September 28th, 2013, 9:19 p.m. UTC, David Gil Oliva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Gil Oliva.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2013, 9:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adjust API in KEmoticons framework: KEmoticonsProvider::save()
-To make KEmoticons API more consistent, deprecate KEmoticonsProvider::save()
and prefer saveTheme() instead.
-Adjust plugins.
-Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::save(),
which was empty. Now it's a pure virtual function. Therefore, I deprecate
it and advice subclassing KEmoticonsProvider.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds. It installs. Tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kemoticons/src/core/kemoticonsprovider.h <span style="color: grey">(85fc7efb8923d76476f0a16f70f8ebb15e451081)</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.h <span style="color: grey">(b8b25f7607d3741dda78d6302c1ed81fbc9211a0)</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.cpp <span style="color: grey">(ed3407cdd45c84d91f2d0057e108b760ff696ff2)</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.h <span style="color: grey">(039a267679919c968bbe4d12c35abb90cf1bcc9b)</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.cpp <span style="color: grey">(a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17)</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.h <span style="color: grey">(8cba6b194eee1543bf13f1177a0e4092f1a10943)</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.cpp <span style="color: grey">(5b5114a14dd94a6ebcba8a6f7dd163f73048189a)</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h <span style="color: grey">(70bafa3fe4ba25c9d6a69634024b2c157235e674)</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp <span style="color: grey">(e9f89eecce3d6e6407113a84cb5200ff66564c19)</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h <span style="color: grey">(0873a635a300e0ed8e38b1d59a535d6ec15b99cb)</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp <span style="color: grey">(0dc92ed092d87a559fe7fa1a40e804843ab73d59)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112984/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>