<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112880/">http://git.reviewboard.kde.org/r/112880/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 29th, 2013, 4:24 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The name "token" surprises me a bit. Is this a usual naming scheme for accessing C++ classes from QML?
Otherwise I would think the QML code would want to just write KColorScheme.
Maybe the registration could be done in a static method, rather than letting the apps do it on their own?
The "NEED TO FIX" in the description can be removed, right?
About the branch: I see that the request is correctly for 5.0 - which means less merging trouble, so it sounds good to me :)
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We can register it as KColorScheme for QML but in C++ it can't have such name as KColorScheme already exists. Token was first that came to my mind, maybe we can name it KColorSchemeQMLWrapper or smth like this?
As Kevin suggested maybe it should be placed at some other place, not kdeui? I don't know all structure of kdelibs so I'm hope you will help me.
Also how can I implement static registration, or what class I can investigate as example?
I have removed NEED TO FIX...</pre>
<br />
<p>- Denis</p>
<br />
<p>On September 29th, 2013, 4:27 p.m. UTC, Denis Kuplyakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Denis Kuplyakov.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2013, 4:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is wrapper to access KColorScheme's methods from QML code.
Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code.
As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme.
More info:
* search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists *</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>includes/CMakeLists.txt <span style="color: grey">(cdf0143)</span></li>
<li>includes/KColorSchemeToken <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(b439e04)</span></li>
<li>kdeui/colors/kcolorscheme.h <span style="color: grey">(17570fd)</span></li>
<li>kdeui/colors/kcolorscheme.cpp <span style="color: grey">(a6650ac)</span></li>
<li>kdeui/colors/kcolorschemetoken.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdeui/colors/kcolorschemetoken.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112880/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>