<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112943/">http://git.reviewboard.kde.org/r/112943/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, compiles so ship it.</pre>
<br />
<p>- Àlex</p>
<br />
<p>On September 25th, 2013, 6:03 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2013, 6:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not much else, only some small adjustments to fit module constraints.
Some dependencies could be cut in the future, but there's nothing obvious.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(eb1ea8c)</span></li>
<li>kparts/AUTHORS <span style="color: grey">()</span></li>
<li>kparts/CMakeLists.txt <span style="color: grey">(042b78f)</span></li>
<li>kparts/COMMENTS <span style="color: grey">()</span></li>
<li>kparts/KPartsConfig.cmake.in <span style="color: grey">()</span></li>
<li>kparts/Mainpage.dox <span style="color: grey">()</span></li>
<li>kparts/autotests/CMakeLists.txt <span style="color: grey">(4746ecb)</span></li>
<li>kparts/autotests/openorsavequestion_unittest.cpp <span style="color: grey">()</span></li>
<li>kparts/autotests/parttest.h <span style="color: grey">()</span></li>
<li>kparts/autotests/parttest.cpp <span style="color: grey">()</span></li>
<li>kparts/src/CMakeLists.txt <span style="color: grey">()</span></li>
<li>kparts/src/browserextension.h <span style="color: grey">()</span></li>
<li>kparts/src/browserextension.cpp <span style="color: grey">()</span></li>
<li>kparts/src/browserinterface.h <span style="color: grey">()</span></li>
<li>kparts/src/browserinterface.cpp <span style="color: grey">()</span></li>
<li>kparts/src/browseropenorsavequestion.h <span style="color: grey">()</span></li>
<li>kparts/src/browseropenorsavequestion.cpp <span style="color: grey">()</span></li>
<li>kparts/src/browserrun.h <span style="color: grey">()</span></li>
<li>kparts/src/browserrun.cpp <span style="color: grey">()</span></li>
<li>kparts/src/browserrun_p.h <span style="color: grey">()</span></li>
<li>kparts/src/browserview.desktop <span style="color: grey">()</span></li>
<li>kparts/src/event.h <span style="color: grey">()</span></li>
<li>kparts/src/event.cpp <span style="color: grey">()</span></li>
<li>kparts/src/fileinfoextension.h <span style="color: grey">()</span></li>
<li>kparts/src/fileinfoextension.cpp <span style="color: grey">()</span></li>
<li>kparts/src/historyprovider.h <span style="color: grey">()</span></li>
<li>kparts/src/historyprovider.cpp <span style="color: grey">()</span></li>
<li>kparts/src/htmlextension.h <span style="color: grey">()</span></li>
<li>kparts/src/htmlextension.cpp <span style="color: grey">()</span></li>
<li>kparts/src/kpart.desktop <span style="color: grey">()</span></li>
<li>kparts/src/krop.desktop <span style="color: grey">()</span></li>
<li>kparts/src/krwp.desktop <span style="color: grey">()</span></li>
<li>kparts/src/listingextension.h <span style="color: grey">()</span></li>
<li>kparts/src/listingextension.cpp <span style="color: grey">()</span></li>
<li>kparts/src/mainwindow.h <span style="color: grey">()</span></li>
<li>kparts/src/mainwindow.cpp <span style="color: grey">()</span></li>
<li>kparts/src/part.h <span style="color: grey">()</span></li>
<li>kparts/src/part.cpp <span style="color: grey">()</span></li>
<li>kparts/src/partmanager.h <span style="color: grey">()</span></li>
<li>kparts/src/partmanager.cpp <span style="color: grey">()</span></li>
<li>kparts/src/plugin.h <span style="color: grey">()</span></li>
<li>kparts/src/plugin.cpp <span style="color: grey">()</span></li>
<li>kparts/src/scriptableextension.h <span style="color: grey">()</span></li>
<li>kparts/src/scriptableextension.cpp <span style="color: grey">()</span></li>
<li>kparts/src/scriptableextension_p.h <span style="color: grey">()</span></li>
<li>kparts/src/statusbarextension.h <span style="color: grey">()</span></li>
<li>kparts/src/statusbarextension.cpp <span style="color: grey">()</span></li>
<li>kparts/src/textextension.h <span style="color: grey">()</span></li>
<li>kparts/src/textextension.cpp <span style="color: grey">()</span></li>
<li>kparts/tests/CMakeLists.txt <span style="color: grey">(66845be)</span></li>
<li>kparts/tests/README <span style="color: grey">()</span></li>
<li>kparts/tests/kpartstest_part1.rc <span style="color: grey">()</span></li>
<li>kparts/tests/kpartstest_part2.rc <span style="color: grey">()</span></li>
<li>kparts/tests/kpartstest_shell.rc <span style="color: grey">()</span></li>
<li>kparts/tests/normalktm.h <span style="color: grey">()</span></li>
<li>kparts/tests/normalktm.cpp <span style="color: grey">()</span></li>
<li>kparts/tests/notepad.h <span style="color: grey">()</span></li>
<li>kparts/tests/notepad.cpp <span style="color: grey">()</span></li>
<li>kparts/tests/notepad.desktop <span style="color: grey">()</span></li>
<li>kparts/tests/notepadpart.rc <span style="color: grey">()</span></li>
<li>kparts/tests/openorsavequestion.cpp <span style="color: grey">()</span></li>
<li>kparts/tests/parts.h <span style="color: grey">()</span></li>
<li>kparts/tests/parts.cpp <span style="color: grey">()</span></li>
<li>kparts/tests/partviewer.h <span style="color: grey">()</span></li>
<li>kparts/tests/partviewer.cpp <span style="color: grey">()</span></li>
<li>kparts/tests/partviewer_shell.rc <span style="color: grey">()</span></li>
<li>kparts/tests/plugin_foobar.rc <span style="color: grey">()</span></li>
<li>kparts/tests/plugin_spellcheck.h <span style="color: grey">()</span></li>
<li>kparts/tests/plugin_spellcheck.cpp <span style="color: grey">()</span></li>
<li>kparts/tests/plugin_spellcheck.rc <span style="color: grey">()</span></li>
<li>kparts/tests/testmainwindow.h <span style="color: grey">()</span></li>
<li>kparts/tests/testmainwindow.cpp <span style="color: grey">()</span></li>
<li>tier3/CMakeLists.txt <span style="color: grey">(5ac107a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112943/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>