<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112950/">http://git.reviewboard.kde.org/r/112950/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 61873dc8f55047f6bba38582d32637bbbe364a82 by Valentin Rusu to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 26th, 2013, 8:13 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Valentin Rusu.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2013, 8:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When calling setShortcut or setDefaultShortcut the new list of shortcuts is not added to the action(Default)Shortcuts map and so the getter methods return an empty shortcut for the given action. This can also be seen when executing the KGlobalShortcutTest::testSetShortcut() testcase against the kde4 kglobalacceld (on the CI it's just skipping this test!). With this patch the testcase succeeds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/xmlgui/src/kglobalaccel.cpp <span style="color: grey">(f5bcfca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112950/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>