<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112957/">http://git.reviewboard.kde.org/r/112957/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 26th, 2013, 11:56 a.m. UTC, <b>Stephen Kelly</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You seem to be doing 3 different things here. Please make sure to do each one in a separate commit.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alright. I'll split it into 3 different commits. Do you want 3 different reviews as well? Or will this one do?</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On September 26th, 2013, 11:11 a.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2013, 11:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed usage of KConfig for saving the size of the dialog and restoring it when the dialog is created.
Removed i18n usage from the test.
Changed all char* strings to QLatin1String
Changed all char to QLatin1Char
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The kmimetypechooser test works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/CMakeLists.txt <span style="color: grey">(25dc6d9)</span></li>
<li>kio/kio/kmimetypechooser.h <span style="color: grey">(9b5a0b7)</span></li>
<li>kio/kio/kmimetypechooser.cpp <span style="color: grey">(c68c6e5)</span></li>
<li>kio/tests/CMakeLists.txt <span style="color: grey">(111f137)</span></li>
<li>kio/tests/kmimetypechoosertest_gui.cpp <span style="color: grey">(5c7280e)</span></li>
<li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(da55c14)</span></li>
<li>tier1/kwidgetsaddons/src/kmimetypechooser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwidgetsaddons/src/kmimetypechooser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kwidgetsaddons/tests/CMakeLists.txt <span style="color: grey">(a78ab21)</span></li>
<li>tier1/kwidgetsaddons/tests/kmimetypechoosertest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112957/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>