<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112900/">http://git.reviewboard.kde.org/r/112900/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 18f9e540fd45a2514cb7a23c49b90ba31331067c by Aleix Pol to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 24th, 2013, 11:14 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 24, 2013, 11:14 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Prepares the module to be moved to its own tier.
There's a rather uncommon case with this module because there's a dependency against KConfig, but it only applies to when it's compiled with the mdnsd backend (only when there's no Avahi but mDns instead). I guess this makes it tier 2, but I'm not all that sure about that.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, there are no tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dnssd/CMakeLists.txt <span style="color: grey">(a2dd8e6)</span></li>
<li>dnssd/KDNSSDConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>dnssd/src/CMakeLists.txt <span style="color: grey">(47587af)</span></li>
<li>dnssd/src/avahi-publicservice.cpp <span style="color: grey">(119c5a8)</span></li>
<li>dnssd/src/mdnsd-publicservice.cpp <span style="color: grey">(2a775fa)</span></li>
<li>dnssd/src/servicemodel.cpp <span style="color: grey">(348db57)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112900/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>