<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112919/">http://git.reviewboard.kde.org/r/112919/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One thing to fix</pre>
 <br />







<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/112919/diff/1/?file=192052#file192052line17" style="color: black; font-weight: bold; text-decoration: underline;">kparts/CMakeLists.txt</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">17</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">ecm_setup_version</span><span class="p">(</span><span class="s">5</span> <span class="s">0</span> <span class="s">0</span> <span class="s">VARIABLE_PREFIX</span> <span class="s">KUNITCONVERSION</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nope.
KPARTS
</pre>
</div>
<br />



<p>- David</p>


<br />
<p>On September 24th, 2013, 5:21 p.m. UTC, Aleix Pol Gonzalez wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>


<p style="color: grey;"><i>Updated Sept. 24, 2013, 5:21 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moved all sources to src.
Installs a KPartsConfig.cmake file.
Documented dependencies.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">builds, tests pass.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kparts/CMakeLists.txt <span style="color: grey">(cae8539)</span></li>

 <li>kparts/KPartsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kparts/browserextension.h <span style="color: grey">()</span></li>

 <li>kparts/browserextension.cpp <span style="color: grey">()</span></li>

 <li>kparts/browserinterface.h <span style="color: grey">()</span></li>

 <li>kparts/browserinterface.cpp <span style="color: grey">()</span></li>

 <li>kparts/browseropenorsavequestion.h <span style="color: grey">()</span></li>

 <li>kparts/browseropenorsavequestion.cpp <span style="color: grey">()</span></li>

 <li>kparts/browserrun.h <span style="color: grey">()</span></li>

 <li>kparts/browserrun.cpp <span style="color: grey">()</span></li>

 <li>kparts/browserrun_p.h <span style="color: grey">()</span></li>

 <li>kparts/browserview.desktop <span style="color: grey">()</span></li>

 <li>kparts/event.h <span style="color: grey">()</span></li>

 <li>kparts/event.cpp <span style="color: grey">()</span></li>

 <li>kparts/fileinfoextension.h <span style="color: grey">()</span></li>

 <li>kparts/fileinfoextension.cpp <span style="color: grey">()</span></li>

 <li>kparts/historyprovider.h <span style="color: grey">()</span></li>

 <li>kparts/historyprovider.cpp <span style="color: grey">()</span></li>

 <li>kparts/htmlextension.h <span style="color: grey">()</span></li>

 <li>kparts/htmlextension.cpp <span style="color: grey">()</span></li>

 <li>kparts/kpart.desktop <span style="color: grey">()</span></li>

 <li>kparts/krop.desktop <span style="color: grey">()</span></li>

 <li>kparts/krwp.desktop <span style="color: grey">()</span></li>

 <li>kparts/listingextension.h <span style="color: grey">()</span></li>

 <li>kparts/listingextension.cpp <span style="color: grey">()</span></li>

 <li>kparts/mainwindow.h <span style="color: grey">()</span></li>

 <li>kparts/mainwindow.cpp <span style="color: grey">()</span></li>

 <li>kparts/part.h <span style="color: grey">(3a8a56d)</span></li>

 <li>kparts/part.cpp <span style="color: grey">()</span></li>

 <li>kparts/partmanager.h <span style="color: grey">()</span></li>

 <li>kparts/partmanager.cpp <span style="color: grey">()</span></li>

 <li>kparts/plugin.h <span style="color: grey">()</span></li>

 <li>kparts/plugin.cpp <span style="color: grey">()</span></li>

 <li>kparts/scriptableextension.h <span style="color: grey">()</span></li>

 <li>kparts/scriptableextension.cpp <span style="color: grey">()</span></li>

 <li>kparts/scriptableextension_p.h <span style="color: grey">()</span></li>

 <li>kparts/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kparts/statusbarextension.h <span style="color: grey">()</span></li>

 <li>kparts/statusbarextension.cpp <span style="color: grey">()</span></li>

 <li>kparts/textextension.h <span style="color: grey">()</span></li>

 <li>kparts/textextension.cpp <span style="color: grey">()</span></li>

 <li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(5dc206d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112919/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>