<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112935/">http://git.reviewboard.kde.org/r/112935/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112935/diff/1/?file=192284#file192284line85" style="color: black; font-weight: bold; text-decoration: underline;">staging/kprintutils/src/kdeprintdialog.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace KdePrint</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">85</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">PageSelectPolicy</span> <span class="n">pageSelectPolicy</span><span class="p">,</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">85</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">PageSelectPolicy</span> <span class="n">pageSelectPolicy</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pedantic. Can we keep the parms all lined up with first line? Same for all below. Ta!</pre>
</div>
<br />
<p>- John</p>
<br />
<p>On September 25th, 2013, 3:21 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and John Layt.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2013, 3:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moves KPrintDialog out of kde4attic into KPrintUtils. Patch contains some changes like KComboBox -> QComboBox etc and also removes couple of image icons, which are no longer needed (was part of a feature merged in qt).
Will do separate commits.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kde4attic/src/kcupsoptionsjobwidget_p.h <span style="color: grey">()</span></li>
<li>staging/kde4attic/src/CMakeLists.txt <span style="color: grey">(74ecc39)</span></li>
<li>staging/kde4attic/src/kcupsoptionspageswidget.ui <span style="color: grey">(0b6231b)</span></li>
<li>staging/kde4attic/src/kcupsoptionspageswidget_p.h <span style="color: grey">()</span></li>
<li>staging/kde4attic/src/kcupsoptionspageswidget_p.cpp <span style="color: grey">(5290405)</span></li>
<li>staging/kde4attic/src/kcupsoptionssettingswidget_p.h <span style="color: grey">()</span></li>
<li>staging/kde4attic/src/kcupsoptionswidget_p.h <span style="color: grey">()</span></li>
<li>staging/kde4attic/src/kcupsoptionswidget_p.cpp <span style="color: grey">(9393fbf)</span></li>
<li>staging/kde4attic/src/kdeprint_nup1.png <span style="color: grey">(9f13429)</span></li>
<li>staging/kde4attic/src/kdeprint_nup2.png <span style="color: grey">(7289a7e)</span></li>
<li>staging/kde4attic/src/kdeprint_nup4.png <span style="color: grey">(b03a539)</span></li>
<li>staging/kde4attic/src/kdeprint_nupother.png <span style="color: grey">(5a7c385)</span></li>
<li>staging/kde4attic/src/kdeprintdialog.h <span style="color: grey">(5d9cd25)</span></li>
<li>staging/kde4attic/src/kdeprintdialog.cpp <span style="color: grey">(13f89a7)</span></li>
<li>staging/kprintutils/src/CMakeLists.txt <span style="color: grey">(a2e56c9)</span></li>
<li>staging/kprintutils/src/config-kprintutils.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112935/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>