<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112909/">http://git.reviewboard.kde.org/r/112909/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 24th, 2013, 7:10 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm torn on that one... If we're sure the remaining features aren't useful, I would propose to just move all the printing stuff from KDE4Attic to KDE4Support. If we're not sure, then we should move the printing stuff from KDE4Attic to the upcoming KPrintUtils (patch pending, it's going to contain a single class so far).
If we go for the KPrintUtils route I think it's a good goal to make it useless over time by keeping to get features merged upstream in Qt. So it's really a question of how fast we feel like deprecating those features.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Either way, these need to be removed as otherwise the print dialog will now have duplicated controls.
So I propose to clean it up first (merge this) then decide what to do next and do it. KPrintUtils seems perfect for this.</pre>
<br />
<p>- Martin</p>
<br />
<p>On September 23rd, 2013, 6:47 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and John Layt.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2013, 6:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Most of the printing features are now part of Qt 5.2 and basically only 4 features are left:
- Page Label
- Page Border
- Mirror Pages
- (Advanced) Job Options
- Server-side paging
I've dropped Job Options as it was quite terrible way to edit/pass CUPS options directly. Server-side paging is actually just a convenient feature as with QPrintDialog, apps that can't do paging themselves need 2 lines of code to set the printing dialog up, thanks to KDEPrintDialog only one line is needed. The rest I've put under Page Options tab in the print dialog. To be honest I don't think they are that useful (or used, even) but we have the code and CUPS support already. If these options were to be dropped however, I'd drop the whole KDE Print support then as it would become just a convenient wrapper around QPrintDialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with Konsole5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kde4attic/src/CMakeLists.txt <span style="color: grey">(4acf1b6)</span></li>
<li>staging/kde4attic/src/kcupsoptionsjobwidget.ui <span style="color: grey">(182b23e)</span></li>
<li>staging/kde4attic/src/kcupsoptionsjobwidget_p.cpp <span style="color: grey">(3c7913d)</span></li>
<li>staging/kde4attic/src/kcupsoptionspageswidget.ui <span style="color: grey">(a68865d)</span></li>
<li>staging/kde4attic/src/kcupsoptionspageswidget_p.h <span style="color: grey">(ede67e6)</span></li>
<li>staging/kde4attic/src/kcupsoptionspageswidget_p.cpp <span style="color: grey">(79c6834)</span></li>
<li>staging/kde4attic/src/kcupsoptionssettingswidget_p.cpp <span style="color: grey">(7b58a37)</span></li>
<li>staging/kde4attic/src/kdeprintdialog.cpp <span style="color: grey">(4722f4c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112909/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>