<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112907/">http://git.reviewboard.kde.org/r/112907/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please split this into multiple patches. The move should be the last patch and it should do almost nothing but the actual move.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112907/diff/2/?file=191797#file191797line6" style="color: black; font-weight: bold; text-decoration: underline;">tier3/kemoticons/autotests/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">target_link_libraries</span><span class="p">(</span><span class="o">${</span><span class="nv">_testname</span><span class="o">}</span> <span class="s">Qt5<span class="hl">::</span>Test</span> <span class="s">KEmoticons</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">target_link_libraries</span><span class="p">(</span><span class="o">${</span><span class="nv">_testname</span><span class="o">}</span> <span class="s">Qt5Test</span> <span class="s">KEmoticons</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is wrong. You probably need to add
find_package(Qt5Test)</pre>
</div>
<br />
<p>- Stephen</p>
<br />
<p>On September 23rd, 2013, 7:24 p.m. UTC, David Gil Oliva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Gil Oliva.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2013, 7:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KEmoticons framework to tier3
Done:
-Adjust the CMakeLists.txt to the new location.
-Substitute kde_add_plugin to add_library.
-Substitute Qt5::Xml to Qt5Xml in target_link_libraries
-Substitute Qt5::Test to Qt5Test in target_link_libraries
TODO:
Modify API to make it more coherent</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/CMakeLists.txt <span style="color: grey">(5c52cbe)</span></li>
<li>staging/kemoticons/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kemoticons/KEmoticonsConfig.cmake.in <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/CMakeLists.txt <span style="color: grey">(b7e890c)</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-1.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-10.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-2.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-4.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-5.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-6.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-8.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/broken-9.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-1.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-1.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-2.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-2.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-3.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-3.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-4.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-4.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-5.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-5.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-6.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-6.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-7.input <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/emoticon-parser-testcases/working-7.output <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/kemoticontest.h <span style="color: grey">()</span></li>
<li>staging/kemoticons/autotests/kemoticontest.cpp <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/core/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/core/kemoticons.h <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/core/kemoticons.cpp <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/core/kemoticonsTheme.desktop <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/core/kemoticonsprovider.h <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/core/kemoticonsprovider.cpp <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.h <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.cpp <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/adium/CMakeLists.txt <span style="color: grey">(c94c0be)</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.h <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.cpp <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/adium/emoticonstheme_adium.desktop <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/kde/CMakeLists.txt <span style="color: grey">(e6d4243)</span></li>
<li>staging/kemoticons/src/providers/kde/emoticonstheme_kde.desktop <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.h <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.cpp <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/pidgin/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/pidgin/emoticonstheme_pidgin.desktop <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/xmpp/CMakeLists.txt <span style="color: grey">(f034de0)</span></li>
<li>staging/kemoticons/src/providers/xmpp/emoticonstheme_xmpp.desktop <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h <span style="color: grey">()</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp <span style="color: grey">()</span></li>
<li>staging/kemoticons/tests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/kemoticons/tests/main.cpp <span style="color: grey">()</span></li>
<li>tier3/CMakeLists.txt <span style="color: grey">(fb4de8f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112907/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>