<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112830/">http://git.reviewboard.kde.org/r/112830/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2013, noon</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">removed dependencies to "kio" library.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Started reorganizing KParts, everything stopped compiling, that fixes it too.
Make string to QStrign casts explicit.
KParts was exporting the "kio" linking, don't do it anymore.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/kmediaplayer/CMakeLists.txt <span style="color: grey">(3d1797d)</span></li>
<li>interfaces/terminal/example/CMakeLists.txt <span style="color: grey">(57201fa)</span></li>
<li>kdewebkit/CMakeLists.txt <span style="color: grey">(cdc5835)</span></li>
<li>khtml/CMakeLists.txt <span style="color: grey">(4e1bb80)</span></li>
<li>khtml/html/ksslkeygen.cpp <span style="color: grey">(a3118da)</span></li>
<li>khtml/html/ksslkeygen_p.h <span style="color: grey">(95c1a71)</span></li>
<li>khtml/java/CMakeLists.txt <span style="color: grey">(ef1675c)</span></li>
<li>khtml/java/tests/CMakeLists.txt <span style="color: grey">(59bef3a)</span></li>
<li>khtml/kmultipart/CMakeLists.txt <span style="color: grey">(6a72fac)</span></li>
<li>khtml/tests/CMakeLists.txt <span style="color: grey">(99b3bdd)</span></li>
<li>kio/CMakeLists.txt <span style="color: grey">(25dc6d9)</span></li>
<li>kparts/CMakeLists.txt <span style="color: grey">(6ab9391)</span></li>
<li>kparts/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kparts/autotests/openorsavequestion_unittest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kparts/autotests/parttest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kparts/autotests/parttest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kparts/browserrun.h <span style="color: grey">(e758241)</span></li>
<li>kparts/tests/CMakeLists.txt <span style="color: grey">(83a97f1)</span></li>
<li>kparts/tests/normalktm.cpp <span style="color: grey">(dcc3a5e)</span></li>
<li>kparts/tests/notepad.cpp <span style="color: grey">(b7c3778)</span></li>
<li>kparts/tests/openorsavequestion.cpp <span style="color: grey">(c080cfc)</span></li>
<li>kparts/tests/openorsavequestion_unittest.cpp <span style="color: grey">(72285b1)</span></li>
<li>kparts/tests/parts.cpp <span style="color: grey">(ee198e3)</span></li>
<li>kparts/tests/parttest.h <span style="color: grey">(19f7651)</span></li>
<li>kparts/tests/parttest.cpp <span style="color: grey">(828666f)</span></li>
<li>kparts/tests/partviewer.cpp <span style="color: grey">(eeeb63a)</span></li>
<li>kparts/tests/plugin_spellcheck.cpp <span style="color: grey">(073144b)</span></li>
<li>kparts/tests/testmainwindow.cpp <span style="color: grey">(fd77af0)</span></li>
<li>kross/modules/CMakeLists.txt <span style="color: grey">(b18c98b)</span></li>
<li>kross/ui/CMakeLists.txt <span style="color: grey">(9e7806d)</span></li>
<li>kutils/CMakeLists.txt <span style="color: grey">(0cb281d)</span></li>
<li>staging/xmlgui/tests/krichtexteditor/CMakeLists.txt <span style="color: grey">(372856b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112830/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>