<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112829/">http://git.reviewboard.kde.org/r/112829/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2013, 3:10 p.m. UTC, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It does not build standalone for me, linking fails: http://paste.kde.org/p05c23fa6
I tried to do xmlgui last week, but realized it needs more work on the underlying frameworks first (which is why I switched to kconfigwidgets)</pre>
</blockquote>
<p>On September 23rd, 2013, 3:55 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Building standalone is not one of the things required by http://community.kde.org/Frameworks/Epics/Splitting_kdelibs .
Also it's something we probably want to deal with at a later stage, when we decide how each should be distributed.</pre>
</blockquote>
<p>On September 23rd, 2013, 4:15 p.m. UTC, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That looks a bit backward to me: how can you be sure you get dependencies correctly if you can't build the framework on its own?</pre>
</blockquote>
<p>On September 23rd, 2013, 4:22 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It should be the same libraries that are specified in LINK_PUBLIC. Either way, I guess we won't know for real until KF5 starts to be actually used after all.</pre>
</blockquote>
<p>On September 23rd, 2013, 4:34 p.m. UTC, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Building the framework standalone already lets you know for real if it is missing any required library, no?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes</pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 19th, 2013, 4:44 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2013, 4:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move xmlgui to tier3, done all the checks.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/CMakeLists.txt <span style="color: grey">(2a31994)</span></li>
<li>staging/xmlgui/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/xmlgui/TODO.xmlgui <span style="color: grey">()</span></li>
<li>staging/xmlgui/XmlGuiConfig.cmake.in <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/kactioncategorytest.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/kactioncategorytest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/kactioncollectiontest.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/kactioncollectiontest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/kglobalshortcuttest.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/kglobalshortcuttest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/kmainwindow_unittest.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/kmainwindow_unittest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/ktoolbar_unittest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/kxmlgui_unittest.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/kxmlgui_unittest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/testguiclient.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/autotests/testxmlguiwindow.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/make_kdepackages.sh <span style="color: grey">()</span></li>
<li>staging/xmlgui/make_kdepackages_updated.py <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/CMakeLists.txt <span style="color: grey">(b1d7d17)</span></li>
<li>staging/xmlgui/src/README <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/TODO <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/aboutkde.png <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/config-xmlgui.h.cmake <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kaboutapplicationconfigattica_p.h.cmake <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kaboutapplicationdialog.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kaboutapplicationdialog.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kaboutapplicationpersonlistview_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kaboutapplicationpersonlistview_p.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kaboutapplicationpersonmodel_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kaboutapplicationpersonmodel_p.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kaboutkdedialog_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kaboutkdedialog_p.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kactioncategory.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kactioncategory.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kactioncollection.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kactioncollection.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kactionconflictdetector.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kbugreport.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kbugreport.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kcheckaccelerators.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kcheckaccelerators.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kdepackages.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kedittoolbar.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kedittoolbar.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kedittoolbar_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kglobalaccel.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kglobalaccel.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kglobalaccel_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kglobalshortcutinfo.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kglobalshortcutinfo.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kglobalshortcutinfo_dbus.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kglobalshortcutinfo_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/khelpclient.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/khelpclient.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/khelpmenu.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/khelpmenu.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kkeysequencewidget.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kkeysequencewidget.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kkeysequencewidget_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kmainwindow.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kmainwindow.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kmainwindow_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kmainwindowiface.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kmainwindowiface_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kmenumenuhandler_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kmenumenuhandler_p.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kpartgui.dtd <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcuteditwidget.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutschemeseditor.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutschemeshelper.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutschemeshelper_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutsdialog.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutsdialog.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutsdialog.ui <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutsdialog_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutseditor.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutseditor.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutseditordelegate.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutseditoritem.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutwidget.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutwidget.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kshortcutwidget.ui <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kswitchlanguagedialog_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kswitchlanguagedialog_p.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/ktoggletoolbaraction.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/ktoggletoolbaraction.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/ktoolbar.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/ktoolbar.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/ktoolbarhandler.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/ktoolbarhandler_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kundoactions.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kundoactions.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlgui.xsd <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlguibuilder.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlguibuilder.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlguiclient.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlguiclient.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlguifactory.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlguifactory.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlguifactory_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlguifactory_p.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlguiversionhandler.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlguiversionhandler_p.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlguiwindow.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/kxmlguiwindow.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/org.kde.KGlobalAccel.xml <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/org.kde.kglobalaccel.Component.xml <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/thumb_frame.png <span style="color: grey">()</span></li>
<li>staging/xmlgui/src/ui_standards.rc <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kbugreporttest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kmainwindowrestoretest.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kmainwindowrestoretest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kmainwindowtest.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kmainwindowtest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/krichtexteditor/CMakeLists.txt <span style="color: grey">(372856b)</span></li>
<li>staging/xmlgui/tests/krichtexteditor/krichtexteditor.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/krichtexteditor/krichtexteditor.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/krichtexteditor/krichtexteditorui.rc <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/krichtexteditor/main.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/krulertest.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/krulertest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/ktoolbartest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kwindowtest.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kwindowtest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kwindowtest.rc <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kxmlguitest.h <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kxmlguitest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kxmlguitest_part.rc <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kxmlguitest_shell.rc <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kxmlguiwindowtest.cpp <span style="color: grey">()</span></li>
<li>staging/xmlgui/tests/kxmlguiwindowtestui.rc <span style="color: grey">()</span></li>
<li>tier3/CMakeLists.txt <span style="color: grey">(fb4de8f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112829/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>